1069605 - Fixes for Settings API race condition errors

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Continuation of bug 1068962.

There were two patches in bug 1068962 that were not as important to land as the others, and one of them caused a Mnw failure. This bug will continue work on figure out how/why that happened and get them landed without blocking bug 1068962 from landing and fixing eideticker/CI work.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 2 (v2) - Only send messages in SettingsLocks when window is live; r=bent

Ben already reviewed this patch in bug 1068962, but it may be causing Mnw failures. Checking here before landing.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 3 (v1) - Make sure settings lock exists before trying to remove it; r=bent

Ben already reviewed this patch in bug 1068962, but it may be causing Mnw failures. Checking here before landing.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Now everything passes. With no changes. No idea why.

https://tbpl.mozilla.org/?tree=Try&rev=111fd93f30f3

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://hg.mozilla.org/integration/b2g-inbound/rev/ba79aa341f34
https://hg.mozilla.org/integration/b2g-inbound/rev/674e62d19031

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8491802 [details] [diff] [review]
Patch 2 (v2) - Only send messages in SettingsLocks when window is live; r=bent

Approval Request Comment
[Feature/regressing bug #]: Bug 900551
[User impact if declined]: Weird error messages if apps close while having messages queued to run.
[Describe test coverage new/current, TBPL]: tbpl logs, b2gperf runs
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8491804 [details] [diff] [review]
Patch 3 (v1) - Make sure settings lock exists before trying to remove it; r=bent

Approval Request Comment
[Feature/regressing bug #]: Bug 900551
[User impact if declined]: Weird error messages if apps close while having messages queued to run.
[Describe test coverage new/current, TBPL]: tbpl logs, b2gperf runs
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba79aa341f34
https://hg.mozilla.org/mozilla-central/rev/674e62d19031

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a7ad950df755
https://hg.mozilla.org/releases/mozilla-aurora/rev/a42a0e6d65fa