Closed Bug 1069605 Opened 5 years ago Closed 5 years ago

Fixes for Settings API race condition errors

Categories

(Core :: DOM: Device Interfaces, defect)

25 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
2.1 S5 (26sep)
Tracking Status
firefox33 --- wontfix
firefox34 --- fixed
firefox35 --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: qdot, Assigned: qdot)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

Continuation of bug 1068962.

There were two patches in bug 1068962 that were not as important to land as the others, and one of them caused a Mnw failure. This bug will continue work on figure out how/why that happened and get them landed without blocking bug 1068962 from landing and fixing eideticker/CI work.
Ben already reviewed this patch in bug 1068962, but it may be causing Mnw failures. Checking here before landing.
Ben already reviewed this patch in bug 1068962, but it may be causing Mnw failures. Checking here before landing.
Now everything passes. With no changes. No idea why.

https://tbpl.mozilla.org/?tree=Try&rev=111fd93f30f3
Comment on attachment 8491802 [details] [diff] [review]
Patch 2 (v2) - Only send messages in SettingsLocks when window is live; r=bent

Approval Request Comment
[Feature/regressing bug #]: Bug 900551
[User impact if declined]: Weird error messages if apps close while having messages queued to run.
[Describe test coverage new/current, TBPL]: tbpl logs, b2gperf runs
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8491802 - Flags: approval-mozilla-aurora?
Comment on attachment 8491804 [details] [diff] [review]
Patch 3 (v1) - Make sure settings lock exists before trying to remove it; r=bent

Approval Request Comment
[Feature/regressing bug #]: Bug 900551
[User impact if declined]: Weird error messages if apps close while having messages queued to run.
[Describe test coverage new/current, TBPL]: tbpl logs, b2gperf runs
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8491804 - Flags: approval-mozilla-aurora?
Attachment #8491802 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8491804 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.