Closed Bug 1069619 Opened 10 years ago Closed 7 years ago

Browser menu button is not labeled.

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Browser
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: eeejay, Assigned: gopalmeena94, Mentored)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1][good first bug][lang=html])

Attachments

(1 file)

https://github.com/mozilla-b2g/gaia/pull/25049
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
The reload button is not labeled for accessibility.
Component: Gaia → Gaia::Browser
Mentor: yzenevich
Whiteboard: [b2ga11y p=1] → [b2ga11y p=1][good first bug][lang=html]
Assignee: nobody → gopalmeena94
I am interested to solve this and this will be my first bug to solve on firefox OS
I am interested to solve this and this will be my first bug to solve on firefox OS
Hi Gopal, Sure, let me know if you need any more info/help/etc.
Oh yes sir. Thanks for help. It will be better if you can give me more information about this bug.
(In reply to Gopal Singh Meena from comment #4) > Oh yes sir. > Thanks for help. > It will be better if you can give me more information about this bug. Hi Gopal, So the menu button can be seen when you load a browser app and follow to some url. It looks like a '...' three dot icon. When the screen reader reads the button it does not have the label. What it should say is 'Menu button'. The markup for the button can be found here: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_chrome.js#L108 You would need to make sure that the element has a correct aria-label attribute applied. It is very similar to this bug 1069616, so if you follow it, the comments, suggestions, instructions are pretty much identical (including the tests).
Hi, just wondering if there has there been any work done on this bug, if not, I am interested in it.
(In reply to Jesal from comment #6) > Hi, just wondering if there has there been any work done on this bug, if > not, I am interested in it. Hi Gopal, Are you still working on this bug?
yes sir currently I am working on this Bug. If I will not I will inform you.
I've tried and come up with this, could you review this for me please.
Attachment #8503544 - Flags: review?(yzenevich)
I've left a few comments on github to see how the few failed tests can be made to pass. Please make the necessary changes and rebase it and push it back.
hello Yura Zenevich sir, after a lot of work i changed some code of attachment 8503544 [details] [review] which i have already attached before some days. But i have question or a problem. when we test this patch on try hook serevr, i got error in Gu and Gij testing. which you can see on this link: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=73c1ecba03e0 the reason for error in Gu testing is bug no. 1081050, which already have been solved or fixed, and i didn't get the mean of reason of error in Gij test. So can you guide me how to solve this issue?
Comment on attachment 8503544 [details] [review] https://github.com/mozilla-b2g/gaia/pull/25049 Looks good from the a11y point of view, redirecting to Alive.
Attachment #8503544 - Flags: review?(yzenevich)
Attachment #8503544 - Flags: review?(alive)
Attachment #8503544 - Flags: a11y-review+
Comment on attachment 8503544 [details] [review] https://github.com/mozilla-b2g/gaia/pull/25049 Actually a couple of nits need to be addressed, please mark me again for a11y-review once you addressed them. Thanks!
Attachment #8503544 - Flags: a11y-review+
sorry sir,Can you specify these two things in more detail :- 1. In apps/system/locales/system.en-US.properties (i) you said new line, sorry sir but i didn't get that mean. (ii) you said "Just leave Menu. no need for button, it will be inferred by the screen reader" it means i should remove this line "menu-button.ariaLabel = Menu Button"
Hi, of course :), so (i) I meant to add an empty new line at the end of the file. (ii) you still need the label, that's the whole point of the fix, it should just be: menu-button.ariaLabel = Menu In fact, someone already added some labels here: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/locales/system.en-US.properties#L556-L559, please add your line there; and you won't have to worry about (i)
And indentation mean i have to write that code in single line instead of two lines. Am i right ?
(In reply to Gopal Singh Meena from comment #16) > And indentation mean i have to write that code in single line instead of two > lines. Am i right ? It has to fit within 80 characters, but if you break it up you need to indent by 2characters (you have 1 there).
Sir I think i have done all changes. Thanks for Mentoring me. please Can you just check it again for me? https://github.com/mozilla-b2g/gaia/pull/25049
Hi, gaia try is showing a gaia unit test failure, is this failure releated to change here ?
Keywords: checkin-needed
(In reply to Carsten Book [:Tomcat] from comment #20) > Hi, gaia try is showing a gaia unit test failure, is this failure releated > to change here ? Yes the pull request needs a couple of updates as mentioned above (it got a conditional r+): * the test needs to pass (the failure is in the new test) * please rebase the pull request with latest master and add the new localization string after this line https://github.com/mozilla-b2g/gaia/blob/master/apps/system/locales/system.en-US.properties#L559 (you won't need the comment then) as mentioned in comment 15. * Update the commit message to the following format: "Bug 1069619 - ... r=alive" Thanks again, hopefully not too long to go.
This bug got a conditional r+, please do not mark it for checkin-needed without getting a confirmation.
Flags: needinfo?(sudheesh1995)
Oops I thought it was the final review. Sorry about that apologies.
Flags: needinfo?(sudheesh1995)
Gopal, Its great work you're doing in here, I've left a few comments on github so that you could complete this bug. Please look into them. :D
Hi Gopal, I added a couple of comments that should help with the test as well. Hopefully that would be it :)
Flags: needinfo?(gopalmeena94)
Hi Gopal, just following up on the bug after vacation, let me know if you have any questions. Thanks.
sorry, sorry i had exams, so i couldn't reply.
Flags: needinfo?(gopalmeena94)
(In reply to Gopal Singh Meena from comment #27) > sorry, sorry i had exams, so i couldn't reply. No worries, let me know when i can take a look again. Thanks!
Hi Gopal, last comments I hope!
Hello sir, I think tests have not started.Could you just restart them?
Hello, would it be possible for me to have a look at this bug as part of my university module? Thanks
Hi, I am new to fixing bugs and I would like to work on the bug please.
blocking-b2g: 2.5? → ---
tracking-b2g: backlog → ---
ux-b2g: - → ---
Interesting to solved this bugs.
I'm a student from coventry university studying an opensource module, I would like to be assigned this as my first bug! Could you please point me in the right direction of how to start
Hi Syed, I think this bug was in review process. As you can see i have patch for this one. If it is still unresolved, @Yura Zenevich will assign it to you.
Flags: needinfo?(yzenevich)
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(yzenevich)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: