Closed
Bug 1069624
Opened 10 years ago
Closed 10 years ago
Make sure shuffle is a toggle button.
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S7 (6mar)
People
(Reporter: yzen, Assigned: eeejay)
References
Details
(Keywords: access, Whiteboard: [b2ga11y p=1])
Attachments
(2 files)
Shuffle button should have toggle button semantics so the screen reader user knows what state it is on.
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8562366 -
Flags: review?(dkuo)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → eitan
Comment 2•10 years ago
|
||
Comment on attachment 8562366 [details] [review]
[PullReq] eeejay:bug-1069624 to mozilla-b2g:master
Looks good to me and apologize for keeping you waiting!
Attachment #8562366 -
Flags: review?(dkuo) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/318fbec15760074a7b9097c3c6cf1c3a9a018a2e
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8578792 [details] [review]
[gaia] eeejay:bug-1069624_v2.2 > mozilla-b2g:v2.2
Rebased on v2.2
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Toggle mode of shuffle button will not be known to screen reader users
[Testing completed]: yes.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: No.
Attachment #8578792 -
Flags: approval-gaia-v2.2?
Updated•10 years ago
|
Attachment #8578792 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 6•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•