1069645 - Download b2g sdk only if running desktop builds

Status: RESOLVED INVALID

(Testing Graveyard :: JSMarionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

if you run gaia-integration with --buildapp as device or emulator, we download the b2g desktop .dmg even though it goes unused for the suite. We should only download this if needed.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: link to PR

Hi Yuren, I'm r?ing since I believe you're familiar with the gaia Makefiles.

This will change means we will only download sdk if we're testing against desktop. Desktop is the default value for BUILDAPP.

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi :mdas,

we are using b2g-desktop to run gaia build system instead of using xulrunner so it's necessary to download it, so I marked it as INVALID but please feel free to reopen it if you think that still is a problem.

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

(In reply to Yuren [:yurenju] (last day: 9/26) from comment #2)
> Hi :mdas,
> 
> we are using b2g-desktop to run gaia build system instead of using xulrunner
> so it's necessary to download it, so I marked it as INVALID but please feel
> free to reopen it if you think that still is a problem.

We only set BUILDAPP for running gaia-marionette tests, and if the BUILDAPP value equal to anything other than desktop, meaning either 'emulator' or 'device', then we do not want to run or build the gaia system and have no need for the b2g sdk.

In the case of 'emulator' or 'device', we only need to use node and node packages to run the tests. I want to remove the unnecessary b2g sdk download because it adds an unneeded download step to the tests and takes a lot of time.

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

ah I forgot, you're right, the b2g sdk is needed to build the profile, which we still want to do for device/emulator. Thanks, I'll resolve this.