Closed Bug 1069671 Opened 6 years ago Closed 6 years ago

Assertion failure: mUpdating, at content/media/mediasource/SourceBuffer.cpp:566 in StopUpdating

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: karlt, Assigned: karlt)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Assertion failure: mUpdating, at content/media/mediasource/SourceBuffer.cpp:566
in StopUpdating running web-platform/tests/media-source/SourceBuffer-abort-updating.html for example.

abort() sets updating to false synchronously, per the spec, but the buffer
append algorithm is not aborted, and so update is dispatched and updateend
again.
Logically, one would cancel the runnable on abort(), but it doesn't matter
exactly when the "update" event is queued, as long as it is async, and so
merely testing mUpdating gives acceptable results with less code.

With this change, the running web platform tests give the same results with
XPCOM_DEBUG_BREAK=abort debug and opt builds.  i.e. no assertion failures.
But only opt tests are currently running on tinderboxen.
Attachment #8493548 - Flags: review?(kinetik)
Attachment #8493548 - Flags: review?(kinetik) → review+
https://hg.mozilla.org/mozilla-central/rev/c9bd08318422
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.