1069847 - [Loop] Wrong attentions screens and impossible hang-up the loop call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[mbarone]

Device: Flame
Build: v2.0 with kk v180 (gecko-2d2ca12 gaia-7edd3b0)
Loop version: c28eaef

STR
1. Create a contact using a valid email as Loop ID. 
2. Log-in into Loop
3. From Contact App perform a loop call to the contact created on step 1(make sure this email ID is not logged into loop)

ACTUAL RESULT
The app shows call end window, then the calling window and finally the unavailable window. Besides is not possible to hang-up the unavailable window

Comment 1

[mbarone]

I forgot. I've the following permission for Loop app
Mic: Deny
Camara:Deny
Mobile ID: ask
Contact: Grant

Comment 2

[mbarone]

Uploaded the video

Comment 3

[Maria Angeles Oteo (:oteo)]

Jose Antonio, as we talked I am assigning to you the bug. Following the same STR and with the same permissions set in Comment 1 I am able to reproduce it. you can see it in this video:

https://www.youtube.com/watch?v=upU80VGl0_s

If I set Mic and Camera permissions to granted, the flow is the correct one, as it's explained in the US bug 1007681, I am notified that the other user can’t be reached with message "Unavailable" and Call failed tone and after that sharing a callback URL screen is shown.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/127

Comment 5

[Maria Angeles Oteo (:oteo)]

According what we have talked, if the GUM permissions are denied it does not make sense trying to establish the call, so prompting the user about the GUM permission issue is enough.

Comment 6

[Maria Angeles Oteo (:oteo)]

Jose Antonio, Borja, I've just realized that similar issue was reported in bug 1054037, so perhaps we can handle it in a unique bug. Wdyt?

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Maria Angeles Oteo (:oteo) from comment #6)
> Jose Antonio, Borja, I've just realized that similar issue was reported in
> bug 1054037, so perhaps we can handle it in a unique bug. Wdyt?

Bug 1054037 is quite similar so let's resolve it as a DUP of this one. Thanks!

Comment 8

[Borja Salguero [:borjasalguero]]

Comment on attachment 8492179 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/127

Small comment to address and we are done! Great job!

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Borja Salguero [:borjasalguero] from comment #8)
> Comment on attachment 8492179 [details] [review]
> Pointer to Github PR
> https://github.com/mozilla-b2g/firefoxos-loop-client/pull/127
> 
> Small comment to address and we are done! Great job!

Thanks, landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/14f15fbeff9c3a61fcedd8c55a970c991566ee55

Comment 12

[mbarone]

Tested with Flame (v2.0 kk v180)
Gecko-9362b48.Gaia-6449cc3
Loop version 041ff17