1069850 - Update lazy loader to load content from theme app

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[Olle Klang]

Attachment: GitHub pull-request

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8492087 [details] [review]
GitHub pull-request

Looks pretty simple. r+.

Comment 3

[[:fabrice] Fabrice Desré]

Olle, can you update your commit message to add r=vingtetun and ask for 2.1 approval on the patch?

Comment 4

[Olle Klang]

(In reply to Fabrice Desré [:fabrice] from comment #3)
> Olle, can you update your commit message to add r=vingtetun and ask for 2.1
> approval on the patch?

I suggest we mark this as INVALID.
After discussion with Wilson Page regarding themeing in 2.2 we've decided not to move the shared style folder so we don't need this patch. Instead we will replace all color values in the current shared/style with css variables.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Olle Klang from comment #4)
> (In reply to Fabrice Desré [:fabrice] from comment #3)
> > Olle, can you update your commit message to add r=vingtetun and ask for 2.1
> > approval on the patch?
> 
> I suggest we mark this as INVALID.
> After discussion with Wilson Page regarding themeing in 2.2 we've decided
> not to move the shared style folder so we don't need this patch. Instead we
> will replace all color values in the current shared/style with css variables.

Hi Olle, I saw you even deleted the branch, should we close it?

Comment 6

[Olle Klang]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #5)
> Hi Olle, I saw you even deleted the branch, should we close it?

Yes, we can close it.