1069862 - MozMobileConnection.getCallBarringOption() with a specific serviceClass doesn't work on some operator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

Consider to have a workaround solution to cover the case.

In gecko implementation, we could always use serviceClass=0 in ril request no matter what is given from api user. Then process the ril response to return the result for that serviceClass asked by user.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #0)
> Consider to have a workaround solution to cover the case.
> 
> In gecko implementation, we could always use serviceClass=0 in ril request
> no matter what is given from api user. Then process the ril response to
> return the result for that serviceClass asked by user.

I rethink about it... As title, this is operator-specific but I doubt how we could have a solution/workaround for all operators on reference phones. As we don't even have a clear definition of the meaning of serviceClass 0, I am concerned whether serviceClass 0 works for all operators. Could it possibly break the original behavior that is working on specifying a certain serviceClass? Unless we have more ideas about the semantic of serviceClass 0, I tend to close this bug as WONTFIX :(

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to Hsin-Yi Tsai (OOO Sep. 22) [:hsinyi] from comment #1)
> (In reply to Szu-Yu Chen [:aknow] from comment #0)
> > Consider to have a workaround solution to cover the case.
> > 
> > In gecko implementation, we could always use serviceClass=0 in ril request
> > no matter what is given from api user. Then process the ril response to
> > return the result for that serviceClass asked by user.
> 
> I rethink about it... As title, this is operator-specific but I doubt how we
> could have a solution/workaround for all operators on reference phones. As
> we don't even have a clear definition of the meaning of serviceClass 0, I am
> concerned whether serviceClass 0 works for all operators. Could it possibly
> break the original behavior that is working on specifying a certain
> serviceClass? Unless we have more ideas about the semantic of serviceClass
> 0, I tend to close this bug as WONTFIX :(

In current design, MMI code like "*#33#" will be implemented by using serviceClass 0. That means if serviceClass 0 doesn't work for all operators, we should also get the problem when sending this MMI code.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #2)
> (In reply to Hsin-Yi Tsai (OOO Sep. 22) [:hsinyi] from comment #1)
> > (In reply to Szu-Yu Chen [:aknow] from comment #0)
> > > Consider to have a workaround solution to cover the case.
> > > 
> > > In gecko implementation, we could always use serviceClass=0 in ril request
> > > no matter what is given from api user. Then process the ril response to
> > > return the result for that serviceClass asked by user.
> > 
> > I rethink about it... As title, this is operator-specific but I doubt how we
> > could have a solution/workaround for all operators on reference phones. As
> > we don't even have a clear definition of the meaning of serviceClass 0, I am
> > concerned whether serviceClass 0 works for all operators. Could it possibly
> > break the original behavior that is working on specifying a certain
> > serviceClass? Unless we have more ideas about the semantic of serviceClass
> > 0, I tend to close this bug as WONTFIX :(
> 
> In current design, MMI code like "*#33#" will be implemented by using
> serviceClass 0. That means if serviceClass 0 doesn't work for all operators,
> we should also get the problem when sending this MMI code.

Oh, yup... thanks for the reminding. Then I am fine with this workaround, thank you Aknow.

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Use serviceClass 0 to query callbarring option

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8495736 [details] [diff] [review]
Use serviceClass 0 to query callbarring option

Review of attachment 8495736 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Use serviceClass 0 to query callbarring option. r=hsinyi

https://tbpl.mozilla.org/?tree=Try&rev=07e75c1c1921

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/0c22e43c9e77

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c22e43c9e77