Closed Bug 1069872 Opened 11 years ago Closed 9 years ago

Loop Standalone should use the same configuration generator utility

Categories

(Hello (Loop) :: Client, defect, P2)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE
Blocking Flags:
backlog tech-debt

People

(Reporter: NiKo, Unassigned)

References

Details

(Whiteboard: [tech-debt][btpp-fix-later][todo-akita][lang=sh|makefile])

User Story

Source code at https://github.com/mozilla/loop, see https://github.com/mozilla/loop/blob/master/CONTRIBUTING.md for more details.

- In bin/server.js, drop the route and associated code for "/config.js"
- In standalone/content/ create a new config.js.in file with a similar format to the production server one [1] but with the existing replacements specified as variables.
- Create a new rule in the Makefile to generate config.js - the rule should be run every time "make runserver" is run (since environment variables may change)
-- use preprocessor.py and specify the environment variables as -D options
- In dist_standalone remove the config file from the dist directory.
-- we don't want to ship it currently as ops manage their version themselves.

[1] https://hello.firefox.com/config.js
Refs bug 987086. Right now ops use the standalone Makefile to generate the standalone's static config.js, while for dev we're using JavaScript in the express local server; that means maintaining synchronized information for configuration values in these two different places by hand, which is painful and error prone. We should find a way to have a single place where to define & maintain these values.
Yes, totally. The dynamic stuff was introduced because it made it easy to define various config files via environment variables, which is more or less required for the functional tests. In retrospect, I think this was a mistake. I've come around to the opinion that since all this content is going to be served as static content in production, our development environment should work the same way as much as possible. I think just having environment variables cause different static files to be generated for the functional tests may be the way to go, but there's some complexity here, because running the functional tests shouldn't interfere with the web server being used for development. See also bug 1059462 for an orthogonal, but somewhat related, bug.
See Also: → 1059462
Whiteboard: [tech-debt]
backlog: --- → Fx36+
backlog: Fx36+ → Fx37+
backlog: Fx37+ → Fx38?
backlog: Fx38? → tech-debt
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
Blocks: 1226706
Rank: 35
The configuration should be applied in the Makefile (i.e., during the build step)
Flags: needinfo?(standard8)
Bumping up priority list as this would be useful cleanup. See user stories for details.
Mentor: standard8
Rank: 35 → 20
User Story: (updated)
Flags: needinfo?(standard8)
Priority: P3 → P2
QA Contact: anthony.s.hughes
Whiteboard: [tech-debt] → [tech-debt][btpp-fix-later][akita-todo][lang=sh|makefile]
User Story: (updated)
Whiteboard: [tech-debt][btpp-fix-later][akita-todo][lang=sh|makefile] → [tech-debt][btpp-fix-later][todo-akita][lang=sh|makefile]
Mentor: standard8
Support for Hello/Loop has been discontinued. https://support.mozilla.org/kb/hello-status Hence closing the old bugs. Thank you for your support.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.