1069891 - "mach reftest --debugger" is broken

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Mats Palmgren (inactive)]

Current mozilla-central tree, rev c8e325eee9e1:

# ./mach reftest --debugger gdb layout/reftests/reftest.list 
 0:00.07 /usr/bin/make -C . -j12 -s -w reftest
make: Entering directory `/md1/objdir/md1/src/mc'
REFTEST INFO | runreftest.py | Running tests: start.

Traceback (most recent call last):
  File "_tests/reftest/runreftest.py", line 545, in <module>
    main()
  File "_tests/reftest/runreftest.py", line 542, in main
    sys.exit(reftest.runTests(args[0], options))
  File "_tests/reftest/runreftest.py", line 250, in runTests
    return self.runSerialTests(testPath, options, cmdlineArgs)
  File "_tests/reftest/runreftest.py", line 346, in runSerialTests
    timeout=options.timeout + 30.0)
  File "/md1/objdir/md1/src/mc/_tests/reftest/automation.py", line 831, in runApp
    cmd, args = self.buildCommandLine(app, debuggerInfo, profileDir, testURL, extraArgs)
  File "/md1/objdir/md1/src/mc/_tests/reftest/automation.py", line 739, in buildCommandLine
    args.extend(debuggerInfo["args"])
TypeError: tuple indices must be integers, not str
make: Leaving directory `/md1/objdir/md1/src/mc'

Comment 1

[Mats Palmgren (inactive)]

Same command works fine on Aurora, fwiw.

Comment 2

[(not currently active) Ted Mielczarek]

Probably a regression from bug 1028090.

Comment 3

[Alessio Placitelli [:Dexter]]

This was fixed in bug 1070042.

Comment 4

[Mats Palmgren (inactive)]

Yes, looks like it's working now, thanks!