106993 - Spurious corruption error if default platform is not available

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P1)

Description

[Stephen Rasku]

I have modified the available platforms by removing all the platforms that we
don't support.  Now if someone logs in from Linux they get the following error:

Error Message
=============
Possible bug database corruption has been detected. Please send mail to
[e-mail] with details of what you were doing
when this message appeared. Thank you. 

src = All Windows 3.1 Windows 95 Windows 98 Windows 2000 Windows NT
Solaris SunOS other
default = Linux

Comment 1

[Stephen Rasku]

Attachment: Fix

Comment 2

[Stephen Rasku]

The attached file fixes make_popup by changing the default to "" if the default
doesn't exist in the src list.  The patch was generated from my modified version
of 2.4.  It shouldn't be much different.

Comment 3

[Stephen Rasku]

s/2.4/2.14/

Comment 4

[Bradley Baetz (:bbaetz)]

Doesn't this negate the error checking on other uses of make_popup? Wouldn't it
be better to make this adjustment in enter_bug.cgi, where we know that doing so
is correct, rather than affect an arbitary number of users, for which triggering
this error does indicate corruption of some sort?

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 55278 [details] [diff] [review]
Fix

I agree with Brad, changing it in CGI.pl is a Bad Thing.
Need to fix enter_bug.cgi instead.

Comment 6

[Gervase Markham [:gerv]]

Don't fix it until the templatisation gets checked in, or you'll probably have
to fix it again :-)

Gerv

Comment 7

[Bradley Baetz (:bbaetz)]

This blocks strict value checks, which affects data integrety checks, so I'd
like to get it done sooner rather than later.

gerv: I can come up with a patch easily enough. When is your enter_bug stuff
being checked in? I'll go look at that patch now, I guess.

Comment 8

[Gervase Markham [:gerv]]

bbaetz: feel free to fix this now :-)

Gerv

Comment 9

[Bradley Baetz (:bbaetz)]

This got fixed as a side effect of how gerv reworked the template, so makepopup
is no longer being used. If the patform isn't in the list, then none of them
will be the default, so the first one in the list will be selected (which is All)

Comment 10

[Bradley Baetz (:bbaetz)]

*** Bug 57822 has been marked as a duplicate of this bug. ***

Comment 11

[Bradley Baetz (:bbaetz)]

*** Bug 137394 has been marked as a duplicate of this bug. ***