1069963 - [Utility Tray] Resize Data Connection in Tray

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Pang [:epang] UX]

Attachment: 2014-09-19-20-39-22.png

Hey Guillaume,

The data connection icons are looking a little too big in the system tray.
The connecting icon is a good size, but when an connection types appear (ex, 3G, H, E, etc.) They are looking a little large.  

Let me know if this is down to the SVGs and I can update.

Thanks!

Comment 1

[Guillaume Marty [:gmarty]]

Sure, you can update the icons. The easiest way is to go to:
https://github.com/gaia-components/gaia-icons/tree/master/images
Download the SVG files you want to update, do the changes and send them back to me. I will do some manual cleaning and update the glyphs and font.

Comment 2

[Eric Pang [:epang] UX]

(In reply to Guillaume Marty [:gmarty] from comment #1)
> Sure, you can update the icons. The easiest way is to go to:
> https://github.com/gaia-components/gaia-icons/tree/master/images
> Download the SVG files you want to update, do the changes and send them back
> to me. I will do some manual cleaning and update the glyphs and font.

Hi Guillaume,

It doesn't look like the icons I created are being used (must have been some existing ones already).  Can you update the data icons with the ones here on box?
https://mozilla.box.com/s/50gj7umue3bi0ain5rpb

Thanks, let me know if you need my help with anything

Comment 3

[Guillaume Marty [:gmarty]]

Attachment: Github dirty patch

Eric, how does it look like with this patch?
This is just a dirty hack of the updated font only. Upon getting ui-r+, I'll update gaia-icons repo properly and the dependency in gaia.

Comment 4

[Eric Pang [:epang] UX]

(In reply to Guillaume Marty [:gmarty] from comment #3)
> Created attachment 8494490 [details] [review]
> Github dirty patch
> 
> Eric, how does it look like with this patch?
> This is just a dirty hack of the updated font only. Upon getting ui-r+, I'll
> update gaia-icons repo properly and the dependency in gaia.

Hey Guillaume, I think it's looking a little small now, can we try increasing the font by around 2-3 px?

Comment 5

[Guillaume Marty [:gmarty]]

Network icons now have a consistent height of 18px in a container of 30px.
Eric, what do you think of that?

Comment 6

[Eric Pang [:epang] UX]

Comment on attachment 8494490 [details] [review]
Github dirty patch

Looks good now, thanks again!

Comment 7

[Wilson Page [:wilsonpage]]

Landed gaia-icons patch and bumped version to v0.6.1 [1].

Now we need to update gaia-icons in Gaia. This is a little trickier than it normally would be as the gaia-icons.js loader API changed slightly in v0.6.0. This means that gaia-header will have to be updated at the same time, as the current version in Gaia uses the old gaia-icons.js loader API.

[1] https://github.com/gaia-components/gaia-icons/releases/tag/v0.6.1

Comment 8

[Guillaume Marty [:gmarty]]

After further discussion, Wilson is going to be responsible for landing this updated icon font together with the dependant components into the master.

Comment 9

[Guillaume Marty [:gmarty]]

Landed in master together with Bug 1076907.