Closed Bug 1070001 Opened 11 years ago Closed 5 years ago

Re-organizing CSS files into components

Categories

(developer.mozilla.org Graveyard :: Code Cleanup, enhancement)

Product:
developer.mozilla.org Graveyard
Component:
Code Cleanup
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: shobson, Unassigned)

References

Details

Talked with :davidwalsh and :openjck about breaking our stylus files down so that each file only contains one "component" and its associated media queries. The goals here are: 1) faster/easier to find a component when one is looking 2) faster/easier to understand how all the declaration work together and morph to deal with media queries
Severity: normal → enhancement
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/c1b6d2db837de16337cdcc89d3cf486f446565b1 Bug #1070001 - Re-organize stylus - Switched from @import to @require. - Files should now require the files they need rather than relying on an @import in a different file. - Files in /include should not generate output. - Tried to break files in main into sensible smaller pieces. - Ran output file through css validator to try to catch errors, fixed what came up. https://github.com/mozilla/kuma/commit/2163ee659e187eaf6f3ef0f16947794a8593ff46 Merge pull request #2762 from stephaniehobson/BUG-1070001-reorg-stylus Bug 1070001: Re-org Stylus
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/8dfb6c0efac25387cb6a117f334972b08d990da6 Bug #1070001 - Re-organize stylus - Switched from @import to @require. - Files should now require the files they need rather than relying on an @import in a different file. - Files in /include should not generate output. - Tried to break files in main into sensible smaller pieces. https://github.com/mozilla/kuma/commit/84c5d49dab0663b566c847057b372e5cc69a6679 Bug 1070001 - Re-org Stylus - Tags All tags now use same class ".tags". There is a modifying class ".tags-small" for the tags in the wiki footer. There is a .tags_tagit file to extend this with over-rides for the jQuery UI plugin. Things that are not tags (list of interests on profile page) no longer use the class ".tags". https://github.com/mozilla/kuma/commit/550c780e28010e49b8390ccd4d5ce67ebb867c80 Merge pull request #2777 from stephaniehobson/BUG-1070001-reorg-stylus-tags Bug 1070001: Re-org Stylus - Tags
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/c48cc014b4a6a038757d4c87f6cca385b272e852 Bug 1070001 - Reorg Stylus - Activity Moved .activity into its own file and changing class names to reflect component structure. Also removed .actions reference from API key page (there were two different uses for the .actions class, but turns out it wasn't doing anything on API page, so re-styled that page to use a different component). Pages to test (you will have to create some API keys): https://developer-local.allizom.org/en-US/profiles/stephaniehobson https://developer-local.allizom.org/en-US/users/account/keys https://github.com/mozilla/kuma/commit/c8876e919f929da18ac7411b47f3c8be8f25684f Merge pull request #2781 from stephaniehobson/BUG-1070001-reorg-stylus-activity Bug 1070001: Re-org Stylus - Activity
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/b7b6f4d248eb2823f48e7064dd7f0fadcd38d30b Bug 1070001 - Reorg Stylus - Light Background Convert all instances of #f4f7f8 into $light-background-color. https://github.com/mozilla/kuma/commit/1324c0af2b2da11b75852a29bd1b0ea79d5e38a5 Merge pull request #2807 from stephaniehobson/BUG-1070001-reorg-stylus-light-background Bug 1070001: Reorg Stylus - Light Background
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/4d257ea197d62d6222f6a5f4e61ca05e2f1b16e5 Bug 1070001: Re-org Stylus - Columns Changed columns to have 3 decimals of accuracy. LTR now lines up on left side and doesn't need negative margin to compensate. https://github.com/mozilla/kuma/commit/980964f36b7503c07e4c4c744b711fe73b79444d Merge pull request #2799 from stephaniehobson/BUG-1070001-reorg-stylus-cols Bug 1070001: Re-org Stylus - Columns
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/3a59528cefaf76a070d0c79a04238ee803c39229 Bug 1070001: Re-org Stylus - demo studio Moved the demo studio CSS into the redesign folder. Broke CSS into smaller files using the existing comments as a guide. Some of these are components, the way I want to organize files in the future, but some of them are not. Weird mish-mash, sorry. https://github.com/mozilla/kuma/commit/f9293b1e273348c7918478b570517b9a1981bd98 Merge pull request #2842 from stephaniehobson/BUG-1070001-reorg-stylus-demos Bug 1070001: Re-org Stylus - demo studio
Blocks: 1104082
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/dcb90e5263d432ea4a654910faf6d071f7f7dd82 BUG 1070001: Re-Org Stylus - wiki Separated classes and IDs in wiki.styl into individual files. Moved some declarations into wiki-edit to be dealt with later. Introduced new comment syntax (long lines) meant to indicate comment hierarchy. As a side effect I made improvements to: - . topicpage-table -- https://developer-local.allizom.org/en-US/docs/ -- https://developer-local.allizom.org/en-US/docs/MDN/ContributeMozilla/Debugging - revsion-list -- https://developer-local.allizom.org/en-US/docs/Mozilla/Debugging$history - pages with kumascript errors - page move and delete pages https://github.com/mozilla/kuma/commit/41466f10481b5dc8e276e5196524fa5d23cb2652 BUG 1070001: Re-Org Stylus - wiki Fix for no-details. These declarations were changed in a PR between when I created this branch and today, they were probably miss placed in a rebase. In light of this I'm going to compare our changes to wiki.styl between when I started on this and today to make sure all changes have been carried forward. https://github.com/mozilla/kuma/commit/7b55a92c2c3317f5b6f4c2de744b7c7862609199 Merge pull request #2929 from stephaniehobson/BUG-1070001-reorg-wiki BUG 1070001: Re-Org Stylus - wiki
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/61e3692b0b6dda02654ab61e947a9fdb3ba3f367 BUG 1070001: Re-Org Stylus - wikiedit Renamed classes to make them more modular: - documents -> document-list - deleted move-decendatnts-list and changed elements to use document-list - move-lookup-link -> parent-suggest-link - contributor-sub -> contributors->sub - choice-list -> revision-list-head - revision-list -> revision-list-contain - compare -> revision-list-controls - various changes to more granualr class names inside revision-list - action -> title-prefix - kumascript-errors -> kserrors - kumascript-details -> kserrors-details - kumascript-detail-toggle -> kserrors-details-toggle Move Page: - changed title to match style of create/edit/translate pages - removed move-decendatnts-list and changed occurances to document-list - removed class "editing" because it was not having any styles applied to it (this allowed me to decrease specificity of the declaraion) Everything else was done to decrease specificity and redundancy, or move declarations into their own files for maintainability. Wasn't sure what to do with the broadly defined elements declared at the beginning of wiki-edit. https://github.com/mozilla/kuma/commit/f043c83447d64594043864d1c4cd55d967a926dc Merge pull request #2965 from stephaniehobson/BUG-1070001-reorg-wikiedit Bug 1070001 reorg wikiedit
Depends on: 1120698
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/f44ca7df7788614e69f8a104f59b867a1d74c0d6 Bug 1070001: Re-org Stylus - Profile - Renamed classes to make them more modular. - Changed profile display and edit pages to use column classes. https://github.com/mozilla/kuma/commit/d6692dff1d51c4529c4754874608041213250eca Merge pull request #2972 from stephaniehobson/BUG-1070001-reorg-profile Bug 1070001 reorg profile
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/d57594902d586f761f2d01289fbb6c96b6ab5c12 Bug 1070001: Reorg stylus - .spec - seperated .spec into its own file. - color and border-color on :before are inherited from color declaration on parent - changed background-color to background for fewer characters - combined declarations where possible - checked all classes are in use - RTL improvements - removed min-width since not applied to inline elements (so it never worked) - moved border width and style declaration to short hand on group declaration https://github.com/mozilla/kuma/commit/26b61718a991ecb2f1057a2709830fdb0bd6c041 Merge pull request #3239 from stephaniehobson/bug-1070001-reorg-spec Bug 1070001: Reorg stylus - .spec
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/1fc6ac424c498db39168cad545eaf932da2b0fcb Bug 1070001: Change socialaccount-providers to have a dash instead of underscore. https://github.com/mozilla/kuma/commit/307503cae6f16c81ace4e71c52984ac71f946f63 Merge pull request #3309 from stephaniehobson/bug-1070001-socialaccount-providers Bug 1070001: Change socialaccount-providers to have a dash
OS: Mac OS X → Unspecified
Hardware: x86 → Unspecified
Depends on: 1207335
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/bd739cf8be7995b0049c45a6ea7c39709fb88a80 Bug 1070001: Organizing custom CSS - remove duplicate bug and warning declarations - move icons to be together in source - add dividers in comments - remove unused fa-trash class - better :last-child control in indicators - remove unused .page-content dd declaration - remove RTL only styling for .page-content (we should fix MDN styles if there's a specific problem rather than over-riding. I could not see a compelling reason for lists on the 1 RTL page with the .page-content class to have its own special list styling) - remove unused coloured icon classes (coloured icons not generated this way anymore) - remove references to unused #nav-sub-docs https://github.com/mozilla/kuma/commit/5731b4605f13c85047bdb41ca651ce45428deaf0 Merge pull request #3670 from stephaniehobson/stylus-reorg Bug 1070001: Organizing custom CSS
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/eca7d63125ad43d74e5f5378d28f8cc7c4fc5010 Bug 1070001: separate communitybox and glossaryLink into components. - move glossaryLink to own file - move communitybox to own file -- RTL improvements -- decrease specificity -- standardize spacing https://github.com/mozilla/kuma/commit/6c0c3d090c92be546ebfec417bb1ba1cca4cf115 Merge pull request #3671 from stephaniehobson/1070001-communitybox Bug 1070001: separate communitybox and glossaryLink into components.
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/2e97fa34d4faa616b04831d5b1e170851becdad9 Bug 1070001: move addpage to component - move addpage-button to own file -- come up with OOCSS class to replace current organization https://github.com/mozilla/kuma/commit/eb0d08d23f16c6b3d7d8656c79b34aec798542f9 Merge pull request #3672 from stephaniehobson/1070001-mega Bug 1070001: move addpage to component
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/262e4bff4e06c41b25f4ef35c26887dfe5a91b93 Bug 1070001: Remove addpage-button The macro has been transitioned to use the new classes outlined in https://github.com/mozilla/kuma/pull/3672 and there are no references* to the old class left on production. We can safely remove this. * the search is turning up 3 references for some reason but I have viewed source on those pages and confirmed it is not in use. Caching? https://github.com/mozilla/kuma/commit/3de8d70e7656377105d56fa8ff8857a1d88c7e14 Merge pull request #3726 from stephaniehobson/1070001-remove-addpage-button Bug 1070001: Remove addpage-button
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/3837b31efbf7f4a6e20d43907c11a48c018411b9 Bug 1070001: Correct set-font-size usage https://github.com/mozilla/kuma/commit/490b845a4cd2944b42b19be709b2d06c5c0de816 Merge pull request #3740 from openjck/bug-1070001-set-font-size Bug 1070001: Correct set-font-size usage
Summary: Re-organizing stylus files into components → Re-organizing CSS files into components
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/f17045bb89abb2c956835686a02ceb65d8883f43 Bug 1070001: Separate large file into small ones https://github.com/mozilla/kuma/commit/69262683b30c874917478006b16ced0b2e4eaaeb Merge pull request #4480 from mozilla/1070001-text-content Bug 1070001: Separate large file into small ones
Assignee: shobson → nobody
MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.