Closed Bug 1070200 Opened 7 years ago Closed 7 years ago

Treeherder UI elements not properly resized in Firefox 34+

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

References

Details

Attachments

(1 file)

Because of bug 1032922, the flexbox "auto" directive doesn't work as it used to. We need a solution that will work both with older browsers (at least for now) and new ones.
This fixes things for me. Tested on Firefox release and Nightly.

Daniel: Could you give me feedback on this approach? I based it on your suggestions in bug 1057047. I'm not yet a flexbox expert so would appreciate any advice you could give me on improving things.
Attachment #8492421 - Flags: review?(jeads)
Attachment #8492421 - Flags: feedback?(dholbert)
Looks good, but one suggestion for making this more concise -- there are actually shorthand keywords that work in both old and new Firefox, for the "flex" values that you're using here.

- "flex: none" expands to "0 0 auto" in old versions, & to "0 0 main-size" in new versions.
- "flex: auto" expands to "1 1 auto" in old versions, & to "1 1 main-size" in new versions.

So, the behavior of the standalone keywords "none" and "auto" should be the same in old and new versions -- which means you won't need two separate lines.

These shorthand keywords have existed since the early days of the CSS flexbox spec, and the editors want to make sure their behavior doesn't change (since they're the among the "recommended" ways to specify flexibility).  So, they should have good backwards- and forwards-compatibility. (I'd expect that they also should work in the "-webkit-flex" declaration as well; though maybe you want to make & test that change separately.)
Attachment #8492421 - Flags: feedback?(dholbert) → feedback+
(In reply to Daniel Holbert [:dholbert] from comment #2)
> Looks good, but one suggestion for making this more concise -- there are
> actually shorthand keywords that work in both old and new Firefox, for the
> "flex" values that you're using here.
> 
> - "flex: none" expands to "0 0 auto" in old versions, & to "0 0 main-size"
> in new versions.
> - "flex: auto" expands to "1 1 auto" in old versions, & to "1 1 main-size"
> in new versions.
> 
> So, the behavior of the standalone keywords "none" and "auto" should be the
> same in old and new versions -- which means you won't need two separate
> lines.
> 
> These shorthand keywords have existed since the early days of the CSS
> flexbox spec, and the editors want to make sure their behavior doesn't
> change (since they're the among the "recommended" ways to specify
> flexibility).  So, they should have good backwards- and
> forwards-compatibility. (I'd expect that they also should work in the
> "-webkit-flex" declaration as well; though maybe you want to make & test
> that change separately.)

Thanks Daniel! I did what you suggested and it worked great on all of Firefox 32, Firefox Nightly, and Chromium.
Attachment #8492421 - Flags: review?(jeads) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
OS: Linux → All
Priority: -- → P3
Hardware: x86_64 → All
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.