Closed
Bug 1070258
Opened 10 years ago
Closed 10 years ago
IonMonkey: Verify that resume points are dominated by their operands
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: sunfish, Assigned: sunfish)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.17 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Attached is a patch which verifies that resume points' operands dominate the blocks that contain them, except magic optimized arguments.
Attachment #8492463 -
Flags: review?(nicolas.b.pierron)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8492463 [details] [diff] [review]
resumepoint-asserts.patch
Review of attachment 8492463 [details] [diff] [review]:
-----------------------------------------------------------------
Sounds like 3 times the same code, I think this deserves a function on its own.
In this function you might want to replace “*block” by “resume->block()”;
Attachment #8492463 -
Flags: review?(nicolas.b.pierron) → feedback+
|
Assignee | |
Comment 2•10 years ago
|
||
Refactored accordingly.
Attachment #8492463 -
Attachment is obsolete: true
Attachment #8499853 -
Flags: review?(nicolas.b.pierron)
|
|
||
Updated•10 years ago
|
Attachment #8499853 -
Flags: review?(nicolas.b.pierron) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•