Closed Bug 1070258 Opened 5 years ago Closed 5 years ago

IonMonkey: Verify that resume points are dominated by their operands

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: sunfish, Assigned: sunfish)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch resumepoint-asserts.patch (obsolete) — Splinter Review
Attached is a patch which verifies that resume points' operands dominate the blocks that contain them, except magic optimized arguments.
Attachment #8492463 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8492463 [details] [diff] [review]
resumepoint-asserts.patch

Review of attachment 8492463 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds like 3 times the same code, I think this deserves a function on its own.
In this function you might want to replace “*block” by “resume->block()”;
Attachment #8492463 - Flags: review?(nicolas.b.pierron) → feedback+
Refactored accordingly.
Attachment #8492463 - Attachment is obsolete: true
Attachment #8499853 - Flags: review?(nicolas.b.pierron)
Attachment #8499853 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/628fabf04fda
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Depends on: 1080991
Depends on: 1090037
You need to log in before you can comment on or make changes to this bug.