when using findElements we dont return a dict with key ELEMENT like we do on findElement

RESOLVED FIXED in mozilla38

Status

Testing
Marionette
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: automatedtester, Assigned: automatedtester)

Tracking

(Blocks: 1 bug, {ateam-marionette-client, ateam-marionette-server})

unspecified
mozilla38
ateam-marionette-client, ateam-marionette-server
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [marionette=1.0])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
This is clearly wrong and we should return

[{ "ELEMENT": <some UUID> }, { "ELEMENT": <some UUID> }] instead of [<some UUID>, <some UUID>, <some UUID>]

This will allow us to have webdriver compat too
(Assignee)

Updated

3 years ago
Assignee: nobody → dburns
Blocks: 721859
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

3 years ago
Keywords: ateam-marionette-client, ateam-marionette-server
(Assignee)

Updated

3 years ago
Whiteboard: [marionette=1.0]
(Assignee)

Updated

3 years ago
Priority: -- → P1
(Assignee)

Comment 1

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=c688b30e3dc1
(Assignee)

Comment 2

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=3a46490e6edb
(Assignee)

Comment 3

3 years ago
Created attachment 8552084 [details]
MozReview Request: bz://1070307/AutomatedTester

/r/2767 - Bug 1070307: have findElements return an array of objects with a key instead of just an array of strings; r=jgriffin

Pull down this commit:

hg pull review -r b5b817d35c3821d766550744a88a4cd5faca7ec5
Attachment #8552084 - Flags: review?(jgriffin)
Comment on attachment 8552084 [details]
MozReview Request: bz://1070307/AutomatedTester

https://reviewboard.mozilla.org/r/2765/#review2001

Hooray for consistency!
Attachment #8552084 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4594c8c47c57
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/4594c8c47c57
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Depends on: 1124815
(Assignee)

Comment 7

3 years ago
Comment on attachment 8552084 [details]
MozReview Request: bz://1070307/AutomatedTester
Attachment #8552084 - Attachment is obsolete: true
Attachment #8618374 - Flags: review+
(Assignee)

Comment 8

3 years ago
Created attachment 8618374 [details]
MozReview Request: Bug 1070307: have findElements return an array of objects with a key instead of just an array of strings; r=jgriffin
You need to log in before you can comment on or make changes to this bug.