Today pane/sidebar: Month and year always "Jan 5555" on startup

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Calendar Views
RESOLVED FIXED
3 years ago
27 days ago

People

(Reporter: aryx, Assigned: Decathlon)

Tracking

Lightning 3.6
4.0.0.1
x86_64
Windows 8.1

Details

Attachments

(1 attachment, 2 obsolete attachments)

Thunderbird Daily + Lightning Trunk 20140919 on Windows 8.1

Launching Thunderbird with Lightning enabled shows "Jan 5555" as month and year in the Today pane sidebar.

Last good: 20140723
First bad: 20140814
No Windows builds between these dates and the Linux one I tried from 20140805 seemed broken.
document.getElementById("monthNameContainer").selectedIndex changes for me while calendar-multiday-view.xml's onResize runs:

          let size;
          if (self.orient == "horizontal") {
              size = scrollbox.boxObject.width;
          } else {
              // Here it's 8.
              size = scrollbox.boxObject.height;
              // Here it's 0.
          }

Is a Promise responsible for that?


Pushlog for comm-central: http://hg.mozilla.org/comm-central/pushloghtml?startdate=2014-07-23&enddate=2014-08-15
(Assignee)

Comment 2

3 years ago
Don't know if it's related, but that one is the same point where scrollbox.boxObject.height always returns 0 during startup on SeaMonkey and it causes Bug 1064089.
(Assignee)

Comment 3

3 years ago
Created attachment 8532898 [details] [diff] [review]
Workaround-v1

I tried to look into the issue, but I'm not able to find the real cause. The regression range and the kind of patches applied in the range don't help me so much since the absence of builds for Windows.

This patch is only a workaround, it sets the default value for month and year in the first panel of the deck to the date of today (the miniday always shows today on startup) instead of "Jan 5555" so when the bug occurs, the date showed is always correct.

If we want a real fix someone else should look into the issue.
Attachment #8532898 - Flags: review?(philipp)
(Assignee)

Updated

3 years ago
Version: Trunk → Lightning 3.6
(Assignee)

Comment 4

3 years ago
Comment on attachment 8532898 [details] [diff] [review]
Workaround-v1

I've just realized that the same bug occurs on the deck of the weekday (the weekdayNameContainer deck) because on startup its selectedIndex is reset to 0.

For this deck it needs something different. Removing the review request.
Attachment #8532898 - Flags: review?(philipp)
(Assignee)

Updated

3 years ago
Duplicate of this bug: 1108492

Updated

3 years ago
Duplicate of this bug: 1104779
(Assignee)

Comment 7

3 years ago
Created attachment 8548481 [details] [diff] [review]
Workaround-v2

I've also added a workaround for the day label.
Overall not an elegant solution, but seeing "Sun Jan 5555" on every startup is by far worse.
Philipp, if you know a different way to fix this, please let me know.
Attachment #8532898 - Attachment is obsolete: true
Attachment #8548481 - Flags: review?(philipp)
Comment on attachment 8548481 [details] [diff] [review]
Workaround-v2

Review of attachment 8548481 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately I can't think of a better way to fix this, lets go with what you've done for now. r=philipp
Attachment #8548481 - Flags: review?(philipp) → review+
(Assignee)

Comment 9

3 years ago
Created attachment 8553672 [details] [diff] [review]
Workaround-v2 for checkin
Assignee: nobody → bv1578
Attachment #8548481 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8553672 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Pushed to comm-central changeset 1140e1eed436
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.0

Comment 11

3 years ago
Just an update
I am still seeing (Jan 5555) this when using TB 37.0b1 and Lightning 3.9b1
As you can see in the 'Target Milestone' field at the top of the bug, this has been fixed in Lightning 4.0, so Lightning 3.9b1 remains affected.

Comment 13

3 years ago
(In reply to Archaeopteryx [:aryx] from comment #12)
> As you can see in the 'Target Milestone' field at the top of the bug, this
> has been fixed in Lightning 4.0, so Lightning 3.9b1 remains affected.

Thanks I missed that.

Will wait for it to be released.

Updated

3 years ago
Duplicate of this bug: 1143654

Updated

2 years ago
Duplicate of this bug: 1150741

Updated

2 years ago
Duplicate of this bug: 1177241

Comment 17

28 days ago
Seems to have returned in TB 55b2, Lightning 5.7b2.

https://support.mozilla.org/en-US/questions/1169131

Comment 18

27 days ago
(In reply to sfhowes from comment #17)
Correct. See Bug 1360914.
You need to log in before you can comment on or make changes to this bug.