107051 - nsNetUtil.h should be made into a static library

Status: RESOLVED DUPLICATE of bug 170983

(Core :: Networking, defect)

Description

[Darin Fisher]

nsNetUtil.h should be made into a static library.  for one thing, this would
allow us to cache necko services (such as the IO service) on behave of each
module that uses necko.

Comment 1

[Bradley Baetz (:bbaetz)]

But then we lose the benefits of inlining (which are probably very small for
most of these functions, I'll admit). Isn't there a better way to do this? I
don't think we all really want a million little static libraries, one for each
module.

Won't a static variable in a static inline routine be shared between stuff which
is linked together, anyway, but not between stuff which is dlopened? ie can't we
make do_GetIOService do something like: (error checking omitted)

static inline nsIIOService* do_GetIOService() {
static nsIIOService* io = nsnull;
if (!io) {
   io = do_GetService(cid);
}return io;
}

and have this Just Work? Or does this require linker magic which isn't guarenteed?

Comment 2

[Darin Fisher]

this would work, but i also wanted to add and xpcom-shutdown observer to free
the io service.  so, i figured a library might be the best way to go.

Comment 3

[Darin Fisher]

unlikely to make it for mozilla1.0

-> future

Comment 4

[Darin Fisher]

-> default owner