1070516 - [e10s] Addons window.content shim breaks some addons

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Glen Mailer]

As discussed in bug 1066623, an exception is being thrown from within the addons compatibility shim.

As far as I can tell, the shim is being applied to `window` objects other than the top-level firefox window (chatzilla's primary window in this case), which then errors because gBrowser is undefined.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-chrome-window-shim

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8492628 [details] [diff] [review]
fix-chrome-window-shim

Review of attachment 8492628 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/addoncompat/multiprocessShims.js
@@ +97,5 @@
>        }
>      }
>  
> +    if (target instanceof Ci.nsIDOMChromeWindow &&
> +        target.document.documentURI == "chrome://browser/content/browser.xul") {

I'm a bit hesitant to hardcode something so fully Firefox-specific to toolkit/.

Do we have any alternatives to this?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I could check if there's a "gMultiProcessBrowser" property on the window. It's also browser-specific, but we already use gBrowser a bunch in toolkit.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

(In reply to Bill McCloskey (:billm) from comment #3)
> I could check if there's a "gMultiProcessBrowser" property on the window.
> It's also browser-specific, but we already use gBrowser a bunch in toolkit.

Ok, I think I might prefer that. r=me with that change.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/194eaa429b65

Pushed with the fix Mike requested.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/194eaa429b65