1070650 - No warning message when clearing Shared URLs history with URLs not revoked

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

Pre-condition: Shared URL tab in Loop mobile application has non revoked URLs

STR
1. Tap on "Clean shared links" button in settings of Loop application
2. Select option "Clean all" 

Expected result:
As there are still not revoked urls, the user should be warned that with this action he will not be able to revoke the URLs

Current Result:
The Shared URLs tab is cleaned without any warning.

Comment 1

[Maria Angeles Oteo (:oteo)]

Rafa, Pau, we need the specific string for this screen.

Just for your info and in case it can help, when we try to delete a unique Share URL not revoked (via long-press on that specific entry) we are showing this message:

"Are you sure you want to delete this link? You will not be able to disable it in the future."

Thanks a lot!

Comment 2

[Rafael Rebolleda]

I believe there is an existing string for this scenario:

removeLinksWarning = By removing all shared links, you won't be able to disable them.

Comment 3

[Maria Angeles Oteo (:oteo)]

(In reply to Rafael Rebolleda from comment #2)
> I believe there is an existing string for this scenario:
> 
> removeLinksWarning = By removing all shared links, you won't be able to
> disable them.

you are right, sorry for bothering you with this, it seems that we have lost the prompt in the client app.

Comment 4

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8496030 [details] [review]
Pull Request

LGTM. r=me

The 'delete' button should be in red, shouldn't it?

Comment 6

[Javier de Prado]

Verified on loop 1.1, V.e01ef76
Flame: 2.0.184based.Gecko-675d616.Gaia-2183b4f
FireE: firee-kk-v2.0-SW2E5-4
Spanish & English