No warning message when clearing Shared URLs history with URLs not revoked

VERIFIED FIXED

Status

Firefox OS
Gaia::Loop
--
major
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: oteo, Assigned: borjasalguero)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile app][blocking][tef-triage][patch available])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Pre-condition: Shared URL tab in Loop mobile application has non revoked URLs

STR
1. Tap on "Clean shared links" button in settings of Loop application
2. Select option "Clean all" 

Expected result:
As there are still not revoked urls, the user should be warned that with this action he will not be able to revoke the URLs

Current Result:
The Shared URLs tab is cleaned without any warning.
(Reporter)

Updated

4 years ago
Blocks: 1034615, 1036490
Whiteboard: [mobile app]
(Reporter)

Updated

4 years ago
Whiteboard: [mobile app] → [mobile app][not blocking]
(Reporter)

Comment 1

4 years ago
Rafa, Pau, we need the specific string for this screen.

Just for your info and in case it can help, when we try to delete a unique Share URL not revoked (via long-press on that specific entry) we are showing this message:

"Are you sure you want to delete this link? You will not be able to disable it in the future."

Thanks a lot!
Flags: needinfo?(hello)
Flags: needinfo?(b.pmm)

Comment 2

4 years ago
I believe there is an existing string for this scenario:

removeLinksWarning = By removing all shared links, you won't be able to disable them.
Flags: needinfo?(hello)
Flags: needinfo?(b.pmm)
(Reporter)

Comment 3

4 years ago
(In reply to Rafael Rebolleda from comment #2)
> I believe there is an existing string for this scenario:
> 
> removeLinksWarning = By removing all shared links, you won't be able to
> disable them.

you are right, sorry for bothering you with this, it seems that we have lost the prompt in the client app.
(Assignee)

Updated

4 years ago
Assignee: nobody → borja.bugzilla
(Reporter)

Updated

4 years ago
Status: NEW → ASSIGNED
(Reporter)

Updated

4 years ago
Severity: normal → major
Whiteboard: [mobile app][not blocking] → [mobile app][blocking][tef-triage]
(Assignee)

Comment 4

4 years ago
Created attachment 8496030 [details] [review]
Pull Request
Attachment #8496030 - Flags: review?(josea.olivera)
(Reporter)

Updated

4 years ago
Whiteboard: [mobile app][blocking][tef-triage] → [mobile app][blocking][tef-triage][patch available]
Comment on attachment 8496030 [details] [review]
Pull Request

LGTM. r=me

The 'delete' button should be in red, shouldn't it?
Attachment #8496030 - Flags: review?(josea.olivera) → review+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 6

4 years ago
Verified on loop 1.1, V.e01ef76
Flame: 2.0.184based.Gecko-675d616.Gaia-2183b4f
FireE: firee-kk-v2.0-SW2E5-4
Spanish & English

Updated

4 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.