1070837 - devtools/framework/toolbox.js |doc| getter not e10s friendly

Status: RESOLVED WORKSFORME

(DevTools :: Framework, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

toolbox.js has a |doc| getter that returns |this.frame.contentDocument;| - this causes a few tests to fail when run in e10s mode.  eg,

35 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_devtools_api.js | The tool is no longer registered 
*************************
A coding exception was thrown in a Promise resolution callback.
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Full message: TypeError: this.doc is undefined
Full stack: Toolbox.prototype.focusTool@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:1032:9
Toolbox.prototype.selectTool/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:1018:7
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:865:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:7
*************************
36 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_devtools_api.js | gDevTools doesn't know about target 
37 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_devtools_api.js | toolbox doesn't know about target. 
JavaScript error: chrome://browser/content/devtools/netmonitor-view.js, line 182: TypeError: this._body.selectedPanel is undefined
38 INFO TEST-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_devtools_api.js | A promise chain failed to handle a rejection 

Fixing this doesn't look trivial, so I'm going to propose we disable the affected tests when run in e10s (referencing this bug) - currently I've identified browser_devtools_api.js and browser_toolbox_options_disable_js.js

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

It's kinda weird that this fails in e10s. It looks like everything being touched here is in-process, so contentDocument should be working. Maybe it's just a timing issue.

Comment 2

[Chris Peterson [:cpeterson]]

These DevTools bugs should probably block e10s from riding to Aurora.

Comment 3

[Chris Peterson [:cpeterson]]

devtools bugs will block the e10s merge to Aurora, but blassey would like them to be tracked by dte10s meta bug 875871, not the tracking-e10s=m6+ flag.

Comment 4

[Eddy Bruel [:ejpbruel]]

This should be a dependency of bug 1030318

Comment 5

[Brian Grinstead [:bgrins]]

This doesn't seem to be a problem anymore, testing on latest fx-team

Comment 6

[Mark Hammond [:markh] [:mhammond]]

See https://dxr.mozilla.org/mozilla-central/search?q=1070837&case=false - can we remove them?

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to Mark Hammond [:markh] from comment #6)
> See https://dxr.mozilla.org/mozilla-central/search?q=1070837&case=false -
> can we remove them?

Yeah, just removed them on fx-team in Bug 1030318: https://hg.mozilla.org/integration/fx-team/rev/700f4ab5423a