Closed Bug 1070973 Opened 10 years ago Closed 9 years ago

Intermittent test_memory_gc_01.html | undefined assertion name - expected PASS

Categories

(DevTools :: Inspector, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: cbook, Unassigned)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Windows 7 32-bit fx-team debug test mochitest-other on 2014-09-22 02:44:09 PDT for push 6ebbcb6f3b03

slave: t-w732-ix-114

https://tbpl.mozilla.org/php/getParsedLog.php?id=48572022&tree=Fx-Team

2123 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/devtools/server/tests/mochitest/test_memory_gc_01.html | undefined assertion name - expected PASS
The failing test is <http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/tests/mochitest/test_memory_gc_01.html?force=1#35>.

It seems like this test is testing for something that is impossible to assert.  There are a ton of reasons why we may be allocating memory in a way that the total measurement after a GC is more than before.  And also we cannot guarantee that a GC doesn't occur before the test initiates one.

I think the test needs to be rewritten to assert that this eventually happens, not that it happens every time.
Comment on attachment 8660463 [details] [diff] [review]
Assert that at some point, the memory measured after a GC is lower than the one before a GC

Review of attachment 8660463 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #8660463 - Flags: review?(nfitzgerald) → review+
https://hg.mozilla.org/mozilla-central/rev/cd96a343381a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: