1071009 - Expose bitrate, frames dropped and frame delay to applications via TB library

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

Partners are using these three parameters:

- bitrate
- frames dropped
- frame delay

to measure WebRTC performance by invoking getStats directly in other WebRTC reference apps. 

We need to expose them via TB library so that they can also measure them in Loop.

Comment 1

[Oscar Patiño González]

Attachment: proposed patch

Comment 2

[Carmen Jimenez Cabezas]

Comment on attachment 8530253 [details] [review]
proposed patch

I've left some comments on the PR, please re-request review after addressing them.

Comment 3

[Oscar Patiño González]

removed unnecessary code from call_manager.js and added patch file for tokbox changes

Comment 4

[Carmen Jimenez Cabezas]

Comment on attachment 8530253 [details] [review]
proposed patch

I've left a nit comment on the PR

Comment 5

[Borja Salguero [:borjasalguero]]

Comment on attachment 8530253 [details] [review]
proposed patch

I think Carmen's review is more than enough here! :)

Comment 6

[Carmen Jimenez Cabezas]

After the last change we have only changed the TB library, and we don't use the changes in the loop app at all. So I think this bug should not be landed as it is now. It would be better to land this when/if if's finally used in loop. For this reason, I'm closing it as invalid for now.

Comment 7

[Carmen Jimenez Cabezas]

Sorry!