1071048 - update sdk/tabs metadata to work in SeaMonkey (for Ghostery)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Philip Chee]

See Bug 1060858 - Ghostery 5.3.1 does not support SeaMonkey (was Ghostery toolbar button doesn't work)

Comment 1

[Philip Chee]

Attachment: Bug1071048Ghostery.patch

This bug just flags the following modules as SeaMonkey compatible:
/lib/sdk/tabs.js
/lib/sdk/tabs/tab.js
/lib/sdk/windows.js

This is the minimum needed to get Ghostery working in SeaMonkey (Bug 1060858). Other changes may be needed (Bug 1069824) but that's out of scope for this bug.

Comment 2

[Tomislav Jovanovic :zombie]

Comment on attachment 8493149 [details] [diff] [review]
Bug1071048Ghostery.patch

Review of attachment 8493149 [details] [diff] [review]:
-----------------------------------------------------------------

i'm reluctant to add "seamonkey" to module metadata when it's something we don't test even manually, let alone have CI for. somebody may read that as official proclamation of "support".

however, with empty `engines` metadata field (or with none at all), the it's assumed all applications are supported, and since all the cases in this bug already support both Firefox and Fennec, we can probably (safely) just remove the engines field, and let SeaMonkey work by default.

so please verify that change would work in SeaMonkey, and submit a patch for review? (preferably as a github PR, since that's how we operate.. see https://github.com/mozilla/addon-sdk/wiki/contribute or feel free to ask if you have any questions).

Comment 3

[Philip Chee]

Attachment: Patch v2.0 fix review issues

Pull request from github

Comment 4

[Tomislav Jovanovic :zombie]

hey Philip, i suggested you should submit a PR with engines field removed, but it looks you just re-submitted the same patch?

was that a mistake, or did you misunderstand me?

Comment 5

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1656

helping Philip with git..

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/fed64453be42b6f6d25c0cc2d7851d802f27be4b
bug 1071048 - update sdk/tabs metadata to work in SeaMonkey

https://github.com/mozilla/addon-sdk/commit/37b672c79f0196af6acd10272f7c16d2522e2a2c
Merge pull request #1656 from zombie/1071048-SeaMonkey-engines

bug 1071048 - update sdk/tabs metadata to work in SeaMonkey, r=@zombie