1071112 - JavaScript error: app://system.gaiamobile.org/js/rocketbar.js, line 325: TypeError: this._port.postMessage is not a function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Gregor Wagner [:gwagner]]

Seen on current trunk with debug gecko build when opening rocket bar.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Pull request - Part 1 - Change search initialization to be promise based

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8493235 [details] [review]
Pull request - Part 1 - Change search initialization to be promise based

Hey guys - just looking for a review here from whoever has time. Thanks!

Comment 3

[Ben Francis [:benfrancis]]

Comment on attachment 8493235 [details] [review]
Pull request - Part 1 - Change search initialization to be promise based

Flagging a system app peer

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8493235 [details] [review]
Pull request - Part 1 - Change search initialization to be promise based

I think this looks good, needs a typo fixed before landing

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8493235 [details] [review]
Pull request - Part 1 - Change search initialization to be promise based

Thanks, I'll fix it up.

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Pull Request - Part 2 - Only listen to open-app when the search window is active

It turns out that the javascript error was actually masking a problem with the way that we listen to the open search event. If we guard this by only listening when the search window is open, it should resolve the issue. Isolating the patch here for ease of review - Alive, could you take a look? Thanks!

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8493976 [details] [review]
Pull Request - Part 2 - Only listen to open-app when the search window is active

lgtm

Comment 8

[Kevin Grandon :kgrandon]

Combined into one PR and landed: https://github.com/mozilla-b2g/gaia/commit/cecfee5ce9ab60cc59a9d24f9a1240eccb2cc094

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8493235 [details] [review]
Pull request - Part 1 - Change search initialization to be promise based

This would be good to uplift to prevent the error being logged, and helping us move faster on blockers in the future. This could also be masking some other issues in rocketbar as we're just blindly throwing errors. This could be a blocker from an engineering standpoint.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Rocketbar feature work.
[User impact] if declined: Not sure, there is potential that this is masking problems though due to the fact that we're just throwing an exception when opening the rocketbar for the first time.
[Testing completed]: Manual and unit tests.
[Risk to taking this patch] (and alternatives if risky): Only touches Rocketbar code, so not a wide change, and tests are passing.
[String changes made]: No.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/f42ec8b0b2dc999c7ef5b239c9998ef0cb5ae8b5