Closed
Bug 1071272
Opened 10 years ago
Closed 10 years ago
Remove the clearUserPref("loop.hawk-session-token.fxa") hack from bug 1071259 when 1071247 is deployed
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox34 fixed, firefox35 fixed)
People
(Reporter: MattN, Assigned: jaws)
References
Details
(Whiteboard: [loop-uplift])
Attachments
(1 file)
1.28 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
A backout of https://hg.mozilla.org/integration/fx-team/rev/b4c808eb3726 should be all that is needed. Testing that the issue in bug 1071247 no longer happens after a restart would be good.
Flags: qe-verify-
Flags: firefox-backlog+
Reporter | ||
Updated•10 years ago
|
Priority: -- → P1
Whiteboard: [blocked by deployment of bug 1071247]
Comment 1•10 years ago
|
||
Hey Matt, it looks like the server has been successfully updated: see Bug 1076905. Is it safe to back out https://hg.mozilla.org/integration/fx-team/rev/b4c808eb3726, or would it be better to create a new patch for the backout? I think this is something we'll want to uplift to Fx34.
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 2•10 years ago
|
||
We'll need a new patch to remove the pref now. I'll take this.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 35.3
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8502553 -
Flags: review?(MattN+bmo)
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8502553 [details] [diff] [review] Patch Review of attachment 8502553 [details] [diff] [review]: ----------------------------------------------------------------- Nit: Update the tense of the the commit message e.g. s/when/since/, s/is/was/ r=me
Attachment #8502553 -
Flags: review?(MattN+bmo) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d09f5f86a803
Whiteboard: [blocked by deployment of bug 1071247] → [fixed in fx-team]
Updated•10 years ago
|
Whiteboard: [fixed in fx-team] → [fixed in fx-team][loop-uplift]
https://hg.mozilla.org/mozilla-central/rev/d09f5f86a803
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team][loop-uplift] → [loop-uplift]
Target Milestone: --- → mozilla35
Updated•10 years ago
|
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•