1071318 - change redirect for /firefox/mobile

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Jennifer Bertsch [:jbertsch]]

Hi-

Let's change the redirect for /firefox/mobile:

old/current redirect point to /firefox/new

new redirect will point to /firefox/android when the new page is live in October 2014

Thx,
Jen

Comment 1

[Jonathan Petto [:jpetto]]

:sgarrity - Would you happen to know where the /firefox/mobile/ redirect is specified? It doesn't seem to be in bedrock...

If it helps, a curl shows me it first redirects to /firefox/fx/, which then redirects to /firefox/new/.

Perhaps this knowledge is contained in one of your ancient, dusty tomes.

Comment 2

[Jennifer Bertsch [:jbertsch]]

+Cmore too

Comment 3

[Steven Garrity [:sgarrity]]

(In reply to Jon Petto [:jpetto] from comment #1)
> :sgarrity - Would you happen to know where the /firefox/mobile/ redirect is
> specified? It doesn't seem to be in bedrock...
> 
> If it helps, a curl shows me it first redirects to /firefox/fx/, which then
> redirects to /firefox/new/.
> 
> Perhaps this knowledge is contained in one of your ancient, dusty tomes.

I've consulted one of the most ancient scripts in the Great Book of Subversion and discovered this:

On line #477 of .htaccess in the mozilla.com svn repo:
 
> RewriteRule ^(en-US/)?firefox/mobile[/]?$ /firefox/fx/ [r=permanent]

http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/tags/production/.htaccess?view=markup#l477

This was created for Bug 768477.

Then, /firefox/fx/ is redirected to /firefox/new/ in the bedrock global.conf: https://github.com/mozilla/bedrock/blob/master/etc/httpd/global.conf#L790

Comment 4

[Chris More [:cmore]]

(In reply to Steven Garrity [:sgarrity] from comment #3)
> (In reply to Jon Petto [:jpetto] from comment #1)
> > :sgarrity - Would you happen to know where the /firefox/mobile/ redirect is
> > specified? It doesn't seem to be in bedrock...
> > 
> > If it helps, a curl shows me it first redirects to /firefox/fx/, which then
> > redirects to /firefox/new/.
> > 
> > Perhaps this knowledge is contained in one of your ancient, dusty tomes.
> 
> I've consulted one of the most ancient scripts in the Great Book of
> Subversion and discovered this:
> 
> On line #477 of .htaccess in the mozilla.com svn repo:
>  
> > RewriteRule ^(en-US/)?firefox/mobile[/]?$ /firefox/fx/ [r=permanent]
> 
> http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/tags/production/.
> htaccess?view=markup#l477
> 
> This was created for Bug 768477.
> 
> Then, /firefox/fx/ is redirected to /firefox/new/ in the bedrock
> global.conf:
> https://github.com/mozilla/bedrock/blob/master/etc/httpd/global.conf#L790

Yeah, we also have /mobile redirected to /firefox/partners.

jbertsch: do we want to change /mobile and /firefox/mobile to point to /firefox/android/ or just /firefox/mobile/ ?

Looks like :sgarrity has dug up the double redirect. We should dig through .htaccess sometime and resolve the multiple redirect issues and do single redirects to the new source. Multiple round trips is a waste of server time.

Comment 5

[Jennifer Bertsch [:jbertsch]]

Hi Jon-

Yes please:  change /mobile and /firefox/mobile to point to /firefox/android/

Thx,
Jen

Comment 6

[Steven Garrity [:sgarrity]]

Since the redirect in the PHP-site .htaccess file is permanent, I'd like to get it out of there as soon as possible. Jon, does this the following plan sound reasonable?

1. Add a /firefox/mobile/ -> /firefox/fx/ redirect to bedrock
2. Remove the similar redirect from the PHP .htaccess file
3. When the new Android page is ready, update the bedrock redirect accordingly

Comment 7

[Steven Garrity [:sgarrity]]

Step 1 is in this PR: https://github.com/mozilla/bedrock/pull/2389

Comment 8

[Jonathan Petto [:jpetto]]

That sounds like a great idea. :)

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/2bc11ac8e8fd9023d2f2816c9f294a711d3512c2
Redirect /firefox/mobile/ to /firefox/new/
Bug 1071318

Comment 10

[Steven Garrity [:sgarrity]]

Attachment: bug-1071318-remove-mobile-redirect.diff

This patch removes /firefox/mobile/ -> /firefox/fx/ redirects that are handled in bedrock as of https://github.com/mozilla/bedrock/pull/2389

Comment 11

[Paul [:pmac] McLanahan]

Comment on attachment 8508132 [details] [diff] [review]
bug-1071318-remove-mobile-redirect.diff

Review of attachment 8508132 [details] [diff] [review]:
-----------------------------------------------------------------

::: .htaccess
@@ -481,5 @@
> -# bug 488327, firefox/mobile -> mobile
> -# bug 767986, except firefox/mobile/faq, firefox/mobile/features and firefox/mobile/platforms
> -RewriteCond %{REQUEST_URI} !firefox/mobile(/faq|/features|/platforms)?[/]?$
> -RewriteRule ^(\w{2,3}(?:-\w{2}(?:-mac)?)?/)?firefox/mobile(.*)[/]?$ /$1mobile$2 [R=permanent]
> -RewriteRule ^(\w{2,3}(?:-\w{2}(?:-mac)?)?/)?mobile(/faq|/features|/platforms)[/]?$ /$1firefox/mobile$2/ [R=permanent]

This matches a lot more than just /firefox/mobile/. Do we no longer need any of this? Do we redirect from /mobile/* anywhere else?

Comment 12

[Steven Garrity [:sgarrity]]

Attachment: bug-1071318-remove-mobile-redirect-specific.diff

I'm not confident enough that the other lines I was removing are no longer needed. Here is a more specific patch that removes only the /firefox/mobile/ -> /firefox/fx/ redirect.

Comment 13

[Steven Garrity [:sgarrity]]

(In reply to Steven Garrity [:sgarrity] from comment #12)
> Created attachment 8508650 [details] [diff] [review]
> bug-1071318-remove-mobile-redirect-specific.diff

Patch applied in trunk in r133681. Merged into tags/stage in r133682 and tags/productions in r133683.

Comment 14

[Steven Garrity [:sgarrity]]

This will be fixed when https://github.com/mozilla/bedrock/pull/2388/ lands.

Comment 15

[Kohei Yoshino [:kohei]]

The PR 2388 has already been merged.