1071334 - changing url fields like ``revision`` and ``fromchange`` don't reload the page

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Cameron Dawson [:camd]]

these url params should reload the page just like ``repo`` does.  So we should have a list of url params to reload with when they change.  otherwise, we should just refilter without a reload.

Comment 1

[Cameron Dawson [:camd]]

I'm pretty sure this is a P1.  Correct me if I'm wrong.  But ifyou're in a repo, and add a ``revision`` value, it's a no-op.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This is just because of the # in the url, right?

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/259eb6c1dfc483b1f840907ac17c511cdccdf465
bug 1071334 - any change to specific url params reloads page

Comment 4

[Cameron Dawson [:camd]]

Wes, the answer is a little more complex than yes or no.  :)  For that particular route, we need to have some url fields that just do filtering without reloading the page.  But others, because they fetch a different set of data from the service, need to reload the page to make updates.  This this has a set of keys that should reload the page.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/912e278a302fcf6d479cf3b73bec83fecf59768b
bug 1071334 - any change to specific url params reloads page