Closed Bug 1071519 Opened 10 years ago Closed 10 years ago

[NFC] nfcd notify multiple tag discover to gecko

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S5 (26sep)

People

(Reporter: dlee, Assigned: dlee)

References

Details

Attachments

(1 file, 1 obsolete file)

pull request to mozilla-b2g/platform_system_nfcd v2
59 bytes, text/x-github-pull-request
dlee
: review+
Details | Review 
In some scenarios, libnfc-nci will detect tag discover multiple-times. Then nfcd may notify the same tag technology in tech_discover event.

Although multiple-tag detection is not support and the tag discover reported by libnfc-nci maybe incorrect, we still could do error handling in nfcd.

In this bug, we will make sure nfcd will not notify the same tag technology in tech discover event

        Attachment #8505394 -
        Flags: review?(allstars.chh)

    
    

    
  
Comment on attachment 8505394 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd

see comments on github

        Attachment #8505394 -
        Flags: review?(allstars.chh)

    
  
Summary: [NFC] Notify the same tag technology to gecko → [NFC] nfcd notify multiple tag discover to gecko

    
    

    
  
After discuss with yoshi, we decide nfcd should not notify multiple tag discover to gecko.

    
  

        Attachment #8505394 -
        Flags: review?(allstars.chh)

    
    

    
  
Comment on attachment 8505394 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd

See github comments for the naming nits.

        Attachment #8505394 -
        Flags: review?(allstars.chh) → review+

    
    

    
  
Update nfcd pull request with nits fixed

    
    

    
  


  

        Attachment #8505394 -
        Attachment is obsolete: true

        Attachment #8507757 -
        Flags: review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: