1071681 - "minutes overdue" and "ETA, X minutes" reversed in treeherder tooltips

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Matt Brubeck (:mbrubeck)]

The tooltip for a job with an expected completion in the future should say "ETA to completed, X mins."  If the expected completion time is in the past, it should say "X mins overdue."

Currently these are reversed.

Fixed by https://github.com/mozilla/treeherder-ui/pull/202

Comment 1

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/d99d767e9a1da865ae93488b4f155a9d084c045d
Bug 1071681 - Fix display of minutes overdue/remaining

These were previously reversed because a sign error in the "remainingMinutes"
calculation.

https://github.com/mozilla/treeherder-ui/commit/54986e19ff224484d98d53aa9b6a962c8f26b60c
Merge pull request #202 from mbrubeck/overdue

Bug 1071681- Fix display of minutes overdue/remaining

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/4cf5891249c0053e6fda8cc3cae653de969f5765
Merge pull request #204 from mozilla/overdue-remaining

Bug 1071681 - Fix display of minutes overdue/remaining

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3bcec36649a68318c71f4daef8736e1d9c2065e5
Bug 1071681 - Fix display of minutes overdue/remaining

These were previously reversed because a sign error in the "remainingMinutes"
calculation.

https://github.com/mozilla/treeherder/commit/f939006702f7874b2fd7057484eeeffc38d20521
Merge pull request #204 from mozilla/overdue-remaining

Bug 1071681 - Fix display of minutes overdue/remaining