1071714 - Write test for bug 1034999 (XUL/style overlays should ignore hashes)

Status: RESOLVED WONTFIX

(Core :: XUL, defect)

Description

[:Gijs (he/him)]

(In reply to Benjamin Smedberg  [:bsmedberg] from bug 1034999 comment #15)
> It should be possible to test this by registering a manifest using
> nsIComponentRegistrar.autoRegister pointing to a test-only manifest.

See the other tests under the chrome/ dir in mozilla-central.

Comment 1

[Mike Hoye [:mhoye]]

Gijs, would you mentor somebody through this?

Comment 2

[:Gijs (he/him)]

(In reply to Mike Hoye [:mhoye] from comment #1)
> Gijs, would you mentor somebody through this?

Sure. Probably not a good first bug, but either way. The test should live in chrome/test/unit, and be modeled after e.g.

http://mxr.mozilla.org/mozilla-central/source/chrome/test/unit/test_bug848297.js

in that it should define a MANIFESTS array that points to a manifest in the data directory that is used for testing, and call registerManifests(MANIFESTS) to register it.

The manifest should contain overlay and style registrations both with and without hashes in the first URL (see: https://developer.mozilla.org/en-US/docs/Chrome_Registration#overlay and https://developer.mozilla.org/en-US/docs/Chrome_Registration#style ).

Then you should get the chrome registry as in the example, and QueryInterface it to Ci.nsIXULOverlayProvider.

The test should then verify that calling chromeReg.getXULOverlays() and chromeReg.getStyleOverlays() with the relevant URLs that are overlaid in the manifest (both with and without the hashes) produces the same (correct) results.

Note that the review should probably be done by someone other than me, though I'm happy to provide initial feedback.

Comment 3

[:Gijs (he/him)]

We removed overlays! \o/