Closed Bug 1071738 Opened 5 years ago Closed 5 years ago

Form autocomplete dialog can take up the entire screen and make it really hard to use fennec

Categories

(Firefox for Android :: General, defect)

34 Branch
All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35
Tracking Status
firefox33 --- affected
firefox34 --- affected
firefox35 --- verified
fennec + ---

People

(Reporter: kats, Assigned: mfinkle)

References

Details

Attachments

(4 files)

Attached image Screenshot
I have a bugmail dashboard with a search field that I use often. Over time, the search field form history has built up and now whenever I put focus into it I get an autocomplete dialog that takes up the entire screen. It's impossible to get rid of because I can't tap anywhere else to remove focus from the field. Hitting the back button makes me go back. I have to tap on the dialog but that inserts the text into the field. If I backspace to clear the text the dialog comes back.
We could look into making the list scrollable, or we could just limit the number of items displayed. As you type the list would filter and you could zero in on the item you want. I kind lean toward the latter because I am not big on making huge lists of scrollable items. It's bad UX and bad for memory.
The list is actually already scrollable, and does filter as you type. I think the height just needs to be clamped more.
We should be smarter in what we show too, it seems like we're showing anything and everything ever recorded.
(In reply to Aaron Train [:aaronmt] from comment #3)
> We should be smarter in what we show too, it seems like we're showing
> anything and everything ever recorded.

It should only be showing things saved for <input> boxes with the same name as the bugzilla <input>
Assignee: nobody → mark.finkle
tracking-fennec: ? → +
This patch simply limits the number of rows displayed to 5. You can still scroll through the list.
Attachment #8496651 - Flags: review?(bnicholson)
Just some minor formatting cleanup
Attachment #8496666 - Flags: review?(bnicholson)
Attachment #8496666 - Flags: review?(bnicholson) → review+
Comment on attachment 8496651 [details] [diff] [review]
formfill-size v0.1

Review of attachment 8496651 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/FormAssistPopup.java
@@ +59,5 @@
>          VALIDATIONMESSAGE;
>      }
>      private PopupType mPopupType;
>  
> +    static final int MAX_VISIBLE_ROWS = 5;

private
Attachment #8496651 - Flags: review?(bnicholson) → review+
Looks like I needed to move getting the row count to inside the "it's an autofill popup list" check.

https://hg.mozilla.org/integration/fx-team/rev/698f664097b4
https://hg.mozilla.org/integration/fx-team/rev/dcf2a3871319
https://hg.mozilla.org/mozilla-central/rev/698f664097b4
https://hg.mozilla.org/mozilla-central/rev/dcf2a3871319
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Verified as fixed in
Build: Firefox for Android 35.0a1 (2014-10-13)
Device: Nexus 4 (Android 4.4.4)
You need to log in before you can comment on or make changes to this bug.