1071738 - Form autocomplete dialog can take up the entire screen and make it really hard to use fennec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot

I have a bugmail dashboard with a search field that I use often. Over time, the search field form history has built up and now whenever I put focus into it I get an autocomplete dialog that takes up the entire screen. It's impossible to get rid of because I can't tap anywhere else to remove focus from the field. Hitting the back button makes me go back. I have to tap on the dialog but that inserts the text into the field. If I backspace to clear the text the dialog comes back.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We could look into making the list scrollable, or we could just limit the number of items displayed. As you type the list would filter and you could zero in on the item you want. I kind lean toward the latter because I am not big on making huge lists of scrollable items. It's bad UX and bad for memory.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

The list is actually already scrollable, and does filter as you type. I think the height just needs to be clamped more.

Comment 3

[Aaron Train [:aaronmt]]

We should be smarter in what we show too, it seems like we're showing anything and everything ever recorded.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #3)
> We should be smarter in what we show too, it seems like we're showing
> anything and everything ever recorded.

It should only be showing things saved for <input> boxes with the same name as the bugzilla <input>

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: formfill-size v0.1

This patch simply limits the number of rows displayed to 5. You can still scroll through the list.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: fennec-formfill-limitrows.png

Screenie

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: formfill-cleanup v0.1

Just some minor formatting cleanup

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 8496651 [details] [diff] [review]
formfill-size v0.1

Review of attachment 8496651 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/FormAssistPopup.java
@@ +59,5 @@
>          VALIDATIONMESSAGE;
>      }
>      private PopupType mPopupType;
>  
> +    static final int MAX_VISIBLE_ROWS = 5;

private

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/1372b8919331
https://hg.mozilla.org/integration/fx-team/rev/ba4b4066c0fe

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out for Android crashes.
https://hg.mozilla.org/integration/fx-team/rev/ae7c7d39ec2e

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=774518&repo=fx-team

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Looks like I needed to move getting the row count to inside the "it's an autofill popup list" check.

https://hg.mozilla.org/integration/fx-team/rev/698f664097b4
https://hg.mozilla.org/integration/fx-team/rev/dcf2a3871319

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/698f664097b4
https://hg.mozilla.org/mozilla-central/rev/dcf2a3871319

Comment 13

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in
Build: Firefox for Android 35.0a1 (2014-10-13)
Device: Nexus 4 (Android 4.4.4)