1071757 - loop functional tests should use a stub/mock/fake simple push server

Status: RESOLVED WONTFIX

(Hello (Loop) :: General, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Loop functional tests currently depend on running against the live simple push server.  Since Tbpl can't afford to have intermittent failures caused by network connectivity issues, we need to do better.

Perhaps the Simple Push folks know of some mock code that we can already use.  First thing to do is to investigate that.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1056151 suggests that the server guys have something in this space already.  Alexis, could the code that the server team uses here support (or be extended to support) an end-to-end call functional test?

Comment 2

[Alexis Metaireau (:alexis)]

Nope, the server doesn't have any simple push mock implementation.

The server doesn't need to have a simple push url, so we didn't need to mock it.

Comment 3

[:shell escalante]

moving to loop general as this could be a client and server bug

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Word on the street is that bbangert might already have a fake push server for testing use.  Ben, is this the case?

Comment 5

[Ben Bangert [:benbangert]]

It's easy to set one up, I documented it here:
https://github.com/mozilla-services/pushgo/blob/feature/test-docs/setup_test_server.rst

This will get a test server with detailed logging of everything that happens on it.

Comment 6

[Alexis Metaireau (:alexis)]

Actually it doesn't has any server-side implications, since the server pings whatever URL it's given.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Awesome; thanks Ben!

Comment 8

[:shell escalante]

Moving these to blocking-loop="tech-debt" so they can be triaged against other tech debt bugs.  When we take a tech-debt bug to work on - just mark it "firefox-backlog"+ and give priority.  Then we'll pull it during iteration planning (or factor it into workload if someone is already working on).

Comment 9

[Ian Bicking (:ianbicking)]

We haven't seen many intermittent test failures due to this, and any work mocking out this specific server would be invalidated by Bug 1131813