Closed Bug 1071835 Opened 5 years ago Closed 5 years ago

this._hawkRequestError is not a function in MozLoopService.hawkRequest

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
Points:
1

Tracking

(firefox34 fixed, firefox35 fixed)

RESOLVED FIXED
mozilla35
Iteration:
35.2
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

(Whiteboard: [loop-uplift])

Attachments

(1 file)

MozLoopService.hawkRequest is defined as:
>  hawkRequest: function(sessionType, path, method, payloadObj) {
>    return MozLoopServiceInternal.hawkRequest(sessionType, path, method, payloadObj).catch(
>      error => {this._hawkRequestError(error);});
>  },

however, _hawkRequestError is defined as a member of MozLoopServiceInternal, so the code should be:

>  hawkRequest: function(sessionType, path, method, payloadObj) {
>    return MozLoopServiceInternal.hawkRequest(sessionType, path, method, payloadObj).catch(
>      error => {MozLoopServiceInternal._hawkRequestError(error);});
>  },
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
Attachment #8493991 - Flags: review?(MattN+bmo) → review+
Iteration: 34.2 → 35.2
https://hg.mozilla.org/mozilla-central/rev/213c8b42fc88
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla35
Comment on attachment 8493991 [details] [diff] [review]
Patch

Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8493991 - Flags: approval-mozilla-aurora?
Comment on attachment 8493991 [details] [diff] [review]
Patch

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8493991 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.