1071835 - this._hawkRequestError is not a function in MozLoopService.hawkRequest

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

MozLoopService.hawkRequest is defined as:
>  hawkRequest: function(sessionType, path, method, payloadObj) {
>    return MozLoopServiceInternal.hawkRequest(sessionType, path, method, payloadObj).catch(
>      error => {this._hawkRequestError(error);});
>  },

however, _hawkRequestError is defined as a member of MozLoopServiceInternal, so the code should be:

>  hawkRequest: function(sessionType, path, method, payloadObj) {
>    return MozLoopServiceInternal.hawkRequest(sessionType, path, method, payloadObj).catch(
>      error => {MozLoopServiceInternal._hawkRequestError(error);});
>  },

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!

https://hg.mozilla.org/integration/fx-team/rev/213c8b42fc88

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/213c8b42fc88

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8493991 [details] [diff] [review]
Patch

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/07c61c94ab8c

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8493991 [details] [diff] [review]
Patch

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.