Closed Bug 107188 Opened 23 years ago Closed 22 years ago

'The Help Toolbar' is incorrect and non-localizable.

Categories

(SeaMonkey :: Help Documentation, defect)

Product:
SeaMonkey
Component:
Help Documentation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: stephend, Assigned: oeschger)

References

Details

Attachments

(3 files)

Fix
2.01 KB, patch
hewitt
: superreview+
Details | Diff | Splinter Review
same add but for commercial, piggy-backing here
764 bytes, patch
Details | Diff | Splinter Review
updated patch for fixing that tooltip
2.64 KB, patch
stephend
: review+
asa
: approval+
Details | Diff | Splinter Review 
In help.xul, 'The Help Toolbar' is incorrect and non-localizable.

It should read:  'Help Toolbar', and should refer to an entity, rather than 
hard-coded (this makes it l10n friendly).

Fix coming up.

Ian, please review, thanks.
Status: NEW → ASSIGNED
Keywords: patch, review
Target Milestone: --- → mozilla1.0
r=oeschger. 
Answer to your last question, stephend: yes, I can. Sorry to keep you waiting.
Comment on attachment 55425 [details] [diff] [review]
Fix

sr=hewitt
Attachment #55425 - Flags: superreview+
inheriting reviews from identical patch to help.dtd on commercial side
Fix.  Ian, thanks for landing commercial's fix.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Ian, your fix was slightly incorrect - you left the article 'The' in.  Can you
remove that in the commercial tree?  Just ref this bug as r/sr.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(I know, could I be any more persnickety?)
Assignee: stephend → oeschger
Status: REOPENED → NEW
Noticed a checkin on Feb 7 to fix bug 124273 changed help.xul back to not having 
a localizable tooltip -  tooltiptext="The Help Toolbar" is back in the file.


ah, darn it. Must have been something I was testing. Sorry that got back in
there. Here is the update plus a little clean-up in the search ui.
Comment on attachment 73676 [details] [diff] [review]
updated patch for fixing that tooltip

r=stephend@netscape.com (word up homey g slice)
Attachment #73676 - Flags: review+
Blocks: 124273
Comment on attachment 73676 [details] [diff] [review]
updated patch for fixing that tooltip

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #73676 - Flags: approval+
Marking FIXED.
Status: NEW → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED
v
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: