'The Help Toolbar' is incorrect and non-localizable.

VERIFIED FIXED in mozilla1.0

Status

VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: stephend, Assigned: oeschger)

Tracking

Trunk
mozilla1.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

In help.xul, 'The Help Toolbar' is incorrect and non-localizable.

It should read:  'Help Toolbar', and should refer to an entity, rather than 
hard-coded (this makes it l10n friendly).

Fix coming up.

Ian, please review, thanks.
Status: NEW → ASSIGNED
Keywords: patch, review
Target Milestone: --- → mozilla1.0
Ian, can you fix commercial tree when I land the Mozilla fix?  Thanks!

http://lxr/commercial/source/extensions/help/resources/locale/en-US/help.dtd
(Assignee)

Comment 3

17 years ago
r=oeschger. 
Answer to your last question, stephend: yes, I can. Sorry to keep you waiting.

Comment 4

17 years ago
Comment on attachment 55425 [details] [diff] [review]
Fix

sr=hewitt
Attachment #55425 - Flags: superreview+
(Assignee)

Comment 5

17 years ago
Created attachment 57108 [details] [diff] [review]
same add but for commercial, piggy-backing here

inheriting reviews from identical patch to help.dtd on commercial side
Fix.  Ian, thanks for landing commercial's fix.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Ian, your fix was slightly incorrect - you left the article 'The' in.  Can you
remove that in the commercial tree?  Just ref this bug as r/sr.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(I know, could I be any more persnickety?)
Assignee: stephend → oeschger
Status: REOPENED → NEW

Comment 9

17 years ago
Noticed a checkin on Feb 7 to fix bug 124273 changed help.xul back to not having 
a localizable tooltip -  tooltiptext="The Help Toolbar" is back in the file.

(Assignee)

Comment 10

17 years ago
Created attachment 73676 [details] [diff] [review]
updated patch for fixing that tooltip

ah, darn it. Must have been something I was testing. Sorry that got back in
there. Here is the update plus a little clean-up in the search ui.
Comment on attachment 73676 [details] [diff] [review]
updated patch for fixing that tooltip

r=stephend@netscape.com (word up homey g slice)
Attachment #73676 - Flags: review+
(Assignee)

Updated

17 years ago
Blocks: 124273

Comment 12

17 years ago
Comment on attachment 73676 [details] [diff] [review]
updated patch for fixing that tooltip

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #73676 - Flags: approval+
(Assignee)

Comment 13

17 years ago
Marking FIXED.
Status: NEW → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED

Comment 14

16 years ago
v
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.