Closed Bug 1072014 Opened 11 years ago Closed 11 years ago

Log.jsm: Allow logging of falsy arguments

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35
Iteration:
35.2

People

(Reporter: MattN, Assigned: MattN)

References

Details

Attachments

(1 file)

v.1 Patch with tests
2.99 KB, patch
Unfocused
: review+
Details | Diff | Splinter Review
BasicFormatter's formatText only checked if message.params is truthy so it doesn't allow logging falsy (non-object) arguments e.g. false or null.
Attachment #8494120 - Flags: review?(bmcbride)
Flags: qe-verify-
Flags: firefox-backlog+
Attachment #8494120 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/integration/fx-team/rev/a7c500849928
Flags: in-testsuite+
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a7c500849928
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: