SampleTable.cpp:595:27: warning: '&&' within '||' [-Wlogical-op-parentheses]

RESOLVED FIXED in mozilla35

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Trunk
mozilla35
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

New build warning with clang on mozilla-inbound:
{
media/libstagefright/frameworks/av/media/libstagefright/SampleTable.cpp:595:27: warning: '&&' within '||' [-Wlogical-op-parentheses]

     if (!mCencDefaultSize && !mCencInfoCount || mCencOffsets.isEmpty()) {
         ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ ~~

media/libstagefright/frameworks/av/media/libstagefright/SampleTable.cpp:595:27: note: place parentheses around the '&&' expression to silence this warning
}
Posted patch fix v1Splinter Review
Here's the trivial fix suggested by the compiler. Edwin, does this parenthesization match the way you intended the logic to be evaluated?
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8494187 - Flags: review?(edwin)
Comment on attachment 8494187 [details] [diff] [review]
fix v1

Review of attachment 8494187 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, that's the one I meant. Thanks for doing that.
Attachment #8494187 - Flags: review?(edwin) → review+
https://hg.mozilla.org/mozilla-central/rev/15082adbb409
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.