1072062 - SampleTable.cpp:595:27: warning: '&&' within '||' [-Wlogical-op-parentheses]

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

New build warning with clang on mozilla-inbound:
{
media/libstagefright/frameworks/av/media/libstagefright/SampleTable.cpp:595:27: warning: '&&' within '||' [-Wlogical-op-parentheses]

     if (!mCencDefaultSize && !mCencInfoCount || mCencOffsets.isEmpty()) {
         ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ ~~

media/libstagefright/frameworks/av/media/libstagefright/SampleTable.cpp:595:27: note: place parentheses around the '&&' expression to silence this warning
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Here's the trivial fix suggested by the compiler. Edwin, does this parenthesization match the way you intended the logic to be evaluated?

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8494187 [details] [diff] [review]
fix v1

Review of attachment 8494187 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, that's the one I meant. Thanks for doing that.

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/15082adbb409

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/15082adbb409