Closed Bug 1072081 Opened 11 years ago Closed 11 years ago

Remove deprecated addon-page module and test

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1642
46 bytes, text/x-github-pull-request
zer0
: review+
Details | Review
No description provided.
Assignee: nobody → evold
OS: Mac OS X → All
Hardware: x86 → All
Summary: Modernize the addon-page test add-on → Modernize the addon-page test add-on and remove hideChromeForLocation usage
We have `addon-page` module deprecated since ages; we are definitely in line with our life-cycle, I think we should just remove the module and the related test.
Flags: needinfo?(rFobic)
Flags: needinfo?(jgriffiths)
Yes, it's deprecated since Australis removed most of the usefulness. Aside: it'd be interesting to see something like addon-page in npm though, with features like: * 'singelton' page, similar to AOM page * custom protocol support eg addon:<somename> instead of resource://... * ???
Flags: needinfo?(jgriffiths)
Comment on attachment 8494223 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1642 r- 'cause we're going to remove the modules and the tests: we can keep this bug open, editing the subject, and updates the PR.
Attachment #8494223 - Flags: review?(zer0) → review-
Summary: Modernize the addon-page test add-on and remove hideChromeForLocation usage → Remove deprecated addon-page module and test
Comment on attachment 8494223 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1642 updated the pr to remove addon-page.
Attachment #8494223 - Flags: review- → review?(zer0)
Comment on attachment 8494223 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1642 LGTM, r+ if all tests are passing
Attachment #8494223 - Flags: review?(zer0) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/b5c57d9652371bf8c768007532540d6bf71107ca Bug 1072081 - Remove deprecated addon-page module and test https://github.com/mozilla/addon-sdk/commit/34141d4d4cc3765f997b352e44b1cca3373ec782 Merge pull request #1642 from erikvold/1072081 Bug 1072081 - Remove deprecated addon-page module and test r=@ZER0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
removing needinfo
Flags: needinfo?(rFobic)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: