1072092 - Status bar icons are screen reader accessible in the full screen apps like the Gallery.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Screen reader user should not be able to swipe to the hidden status bar icons but currently can.
Steps to reproduce with screen reader:
* Open a Gallery app
* Swipe all the way right until the screen reader reaches the end.
* Expected: screen reader should stop on the last visible item on the screen.
* Observed: screen reader steps into the invisible status bar icons.

Comment 1

[Tanveer Ali]

Can this bug be assigned to me please

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Tanveer, sure, give it a try. Let me know if you have any additional questions!

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Tanveer, let me know if you have any questions about the bug. Thanks!

Comment 4

[Tanveer Ali]

(In reply to Yura Zenevich [:yzen] from comment #3)
> Hi Tanveer, let me know if you have any questions about the bug. Thanks!

Thank's Yura

Where can I access the code to make changes


In my module I've been told to go find a bug and then to fix i'm not sure where i can look at the code in order to fix  it

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Tanveer Ali from comment #4)
> (In reply to Yura Zenevich [:yzen] from comment #3)
> > Hi Tanveer, let me know if you have any questions about the bug. Thanks!
> 
> Thank's Yura
> 
> Where can I access the code to make changes
> 
> 
> In my module I've been told to go find a bug and then to fix i'm not sure
> where i can look at the code in order to fix  it

Yes, it's the statusbar icons are located here: https://github.com/yzen/gaia/blob/master/apps/system/index.html#L503-L538. There are 2 containers for them in the HTML: the ones with ids "statusbar-maximized" and "statusbar-minimized". You can find styling for these containers here: https://github.com/yzen/gaia/blob/master/apps/system/style/statusbar/statusbar.css. So what you would need to do is to add an additional condition in the existing CSS rules for the case that's described in the bug - the full screen and full screen layoyt apps.

Comment 6

[Tanveer Ali]

My teacher has asked 

could you direct me to the relevent tools and development environment requirements to fix this bug

thanks

Comment 7

[Tanveer Ali]

I'm pretty sure a simple html editor is suffice right..

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Tanveer Ali from comment #7)
> I'm pretty sure a simple html editor is suffice right..

Correct, this should be a good one: http://www.sublimetext.com/

Comment 9

[ankitladhania]

Hi yura,
Can you please tell me if i can produce this bug on desktop?

Comment 10

[ankitladhania]

Hi yura,
I'm ready to do it if this bug can be reproduced and checked in desktop.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] yzen:bug-1072092 > mozilla-b2g:master

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8568113 [details] [review]
[gaia] yzen:bug-1072092 > mozilla-b2g:master

Looks good, but I am asking Michael to double confirm.

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8568113 [details] [review]
[gaia] yzen:bug-1072092 > mozilla-b2g:master

Didn't see any visual difference with the statusbar behavior with this patch. Taking Yura's word for it this fixes accessibility, r=me

Comment 14

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f98dae4db96034a041a9273e0bd10fdff96c4615

Comment 15

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8568113 [details] [review]
[gaia] yzen:bug-1072092 > mozilla-b2g:master

[Approval Request Comment] This pull request makes status bar icons hidden from screen readers when they are not on screen in full screen apps.
[Bug caused by] (feature/regressing bug #): improvement, not a bug
[User impact] if declined: If declined, the screen reader users will be able to step into status bar icons, even when they are not visible which is very confusing.
[Testing completed]: on device
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 16

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8568113 [details] [review]
[gaia] yzen:bug-1072092 > mozilla-b2g:master

Removing for now.

Comment 17

[Yura Zenevich [:yzen] (please use "needinfo")]

This pull request caused a regression:
Steps to reproduce:
* Go into fullscreen app , such as video
* Turn the screen off
* Turn the screen on
Expected: statusbar icons visible
Observed: statusbar icons hidden.

Comment 18

[Yura Zenevich [:yzen] (please use "needinfo")]

Backed out https://github.com/mozilla-b2g/gaia/commit/b4088654958dfbfefda13bc130d8f58f08804430

Comment 19

[GitHub Autolander Bot]

Attachment: [gaia] yzen:bug-1072092 > mozilla-b2g:master

Comment 20

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8569645 [details] [review]
[gaia] yzen:bug-1072092 > mozilla-b2g:master

Statusbar icons should now be correctly visible when in lockscreen after screen off from a fullscreen app.

Comment 21

[Kevin Grandon :kgrandon]

Comment on attachment 8569645 [details] [review]
[gaia] yzen:bug-1072092 > mozilla-b2g:master

Left a comment on github, but this seems fine to me. Thanks!

Comment 22

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6c1396b510ab325d11317431903908083dc1abf6

Comment 23

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8569645 [details] [review]
[gaia] yzen:bug-1072092 > mozilla-b2g:master

[Approval Request Comment] This pull request makes status bar icons hidden from screen readers when they are not on screen in full screen apps.
[Bug caused by] (feature/regressing bug #): improvement, not a bug
[User impact] if declined: If declined, the screen reader users will be able to step into status bar icons, even when they are not visible which is very confusing.
[Testing completed]: on device
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 24

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/49b702cca18836d3e5843ec83a3aecb1fc382e08

Comment 25

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed for the latest Nightly 3.0 build.

Actual Results:  The status bar icons and search cannot be selected with the screen reader while in a full screen app.

Environmental Variables:
Device: Flame 3.0 KK (Full Flash) (319 MB)
BuildID: 20150303010233
Gaia: c8ed1085a67490a1ecd7f275e5de9487e1b93b1d
Gecko: 0b3c520002ad
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

This issue is NOT fixed in the latest Nightly 2.2 build which does contain this commit.

Actual Results: The user can still select the search section of the status bar with the screen reader on full screen apps.

Environmental Variables:
Device: Flame 2.2 KK (Full Flash) (319 MB)
BuildID: 20150303002527
Gaia: 3d188c414e30acc392253d5389a42352fcfbc183
Gecko: c89aad487aa5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 26

[Yura Zenevich [:yzen] (please use "needinfo")]

This is tracked in bug 1135805 which is about to re-land in master (and then, hopefully, in 2.2). This particular bug is for the status bar icons only.

Jayme, can we resolve this one?

Comment 27

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Yura: If the search bar is tracked in another issue then I can verify that this bug is fixed on 2.2 as well.

Comment 28

[Yura Zenevich [:yzen] (please use "needinfo")]

Yes bug 1135805 is for the search bar.