Closed
Bug 1072110
Opened 11 years ago
Closed 11 years ago
_concatenate_js assumes javascript_urls is an array
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: glob, Assigned: glob)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.83 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
_concatenate_js assumes javascript_urls is an array, mostly because that's what the documentation for that variable says:
> javascript_urls: list. List of URLs to Javascript
unfortunately there are a two templates which pass in a string instead of a list.
i'll fix those templates to use an array, and also update _concatenate_js to support both.
Attachment #8494253 -
Flags: review?(dkl)
Severity: normal → major
Target Milestone: --- → Bugzilla 5.0
|
||
Updated•11 years ago
|
Depends on: 1064395
Keywords: regression
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → 4.5.5
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8494253 [details] [diff] [review]
1072110_1.patch
Review of attachment 8494253 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8494253 -
Flags: review?(dkl) → review+
|
|
||
Updated•11 years ago
|
Flags: approval?
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
e877bb3..03c8528 master -> master
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
ce91bc0..6612062 master -> master
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: approval? → approval+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•