Closed
Bug 1072118
Opened 11 years ago
Closed 11 years ago
Uncaught promise rejection from gmpInstallManager.simpleCheckAndInstall()
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 35
People
(Reporter: mossop, Assigned: mossop)
Details
Attachments
(1 file)
|
1020 bytes,
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
We may not care about doing anything with the promise rejection but simpleCheckAndInstall already logs a sane error message, we don't need the log spew caused by the uncaught promise rejection, particularly since this can cause test failures in some harnesses.
Attachment #8494265 -
Flags: review?(netzen)
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8494265 [details] [diff] [review]
patch
Review of attachment 8494265 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, I wasn't aware that we logged unfulfilled promise rejections.
Attachment #8494265 -
Flags: review?(netzen) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in
before you can comment on or make changes to this bug.
Description
•