1072159 - Emphasise treeherder links in Try server emails & fix links for try-comm-central

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Ed Morley [:emorley]]

Bug 1043880 added links to treeherder to the emails sent to pushers after they make a push to try. 

It's now time to adjust the wording added there to reflect that treeherder is no longer experimental & to encourage more people to give it a try over TBPL.

Comment 1

[Ed Morley [:emorley]]

Attachment: Emphasise treeherder URLs in Try emails & fix for try-comm-central

* Emphasise treeherder over TBPL, since the treeherder transition is imminent.
* s/thunderbird-try/try-comm-central/ for treeherder, now that it uses the
  hg/buildbot name (bug 1035222).
* Remove unused import and fix flake8 whitespace warning.

Note: Bug 1072163 will be making the TBPL output go away, which is why I've gone for the if else assignment, since it will be much cleaner once that bug has landed.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8494458 [details] [diff] [review]
Emphasise treeherder URLs in Try emails & fix for try-comm-central

lgtm

Comment 3

[Ed Morley [:emorley]]

Thanks :-)

https://hg.mozilla.org/build/buildbotcustom/rev/075057c36097

Comment 4

[Pete Moore [:pmoore][:pete]]

Something here landed in production today: https://wiki.mozilla.org/ReleaseEngineering/Maintenance#Reconfigs_.2F_Deployments

Comment 5

[Ed Morley [:emorley]]

Working, eg:

{
Thank you for your try submission. It's the best!

Results will be displayed on Treeherder as they come in:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=54dde8fc5d66

Alternatively, view them on TBPL (soon to be depreciated):
https://tbpl.mozilla.org/?tree=Try&rev=54dde8fc5d66
}

Comment 6

[Birunthan Mohanathas [:poiru]]

Trivial follow-up to fix a typo:
https://hg.mozilla.org/build/buildbotcustom/rev/b274862b4585