Closed Bug 1072191 Opened 10 years ago Closed 10 years ago

Move normalization of alternative chars to LayoutNormalizer

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S7 (24Oct)

People

(Reporter: mnjul, Assigned: mnjul)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

Patch (PR @ GitHub)
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review 
After bug 1044525 lands, we shall move the normalization of layouts in |LayoutLoader._normalizeLayout| to LayoutNormalizer.
Attached file Patch (PR @ GitHub) — 
This patch resolves this bug and bug 1074613. It's cloned from my patch of bug 1072186 with freezings removed.

Tim, could you check? Your original review comments have been addressed. Thanks.
Assignee: nobody → jlu
Attachment #8506006 - Flags: review?(timdream)
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S7 (24Oct)
Comment on attachment 8506006 [details] [review]
Patch (PR @ GitHub)

Looks good except for the nits. Let's do another round of review after they are addressed.
Attachment #8506006 - Flags: review?(timdream) → feedback+
Comment on attachment 8506006 [details] [review]
Patch (PR @ GitHub)

Alright, issues fixed. Please check again, thanks!
Attachment #8506006 - Flags: feedback+ → review?(timdream)
Attachment #8506006 - Flags: review?(timdream) → review+
Waiting for Gaia-try before landing: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=a56d4123cd82 ...that Gij run takes soooooo looooong.
Master: https://github.com/mozilla-b2g/gaia/commit/dae2dc48fe1159db6c359fc421d93fcf5b04b068
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 1101391
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: