Closed
Bug 1072191
Opened 10 years ago
Closed 10 years ago
Move normalization of alternative chars to LayoutNormalizer
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S7 (24Oct)
People
(Reporter: mnjul, Assigned: mnjul)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
After bug 1044525 lands, we shall move the normalization of layouts in |LayoutLoader._normalizeLayout| to LayoutNormalizer.
|
Assignee | |
Comment 1•10 years ago
|
||
This patch resolves this bug and bug 1074613. It's cloned from my patch of bug 1072186 with freezings removed.
Tim, could you check? Your original review comments have been addressed. Thanks.
Assignee: nobody → jlu
Attachment #8506006 -
Flags: review?(timdream)
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S7 (24Oct)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8506006 [details] [review]
Patch (PR @ GitHub)
Looks good except for the nits. Let's do another round of review after they are addressed.
Attachment #8506006 -
Flags: review?(timdream) → feedback+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8506006 [details] [review]
Patch (PR @ GitHub)
Alright, issues fixed. Please check again, thanks!
Attachment #8506006 -
Flags: feedback+ → review?(timdream)
|
|
||
Updated•10 years ago
|
Attachment #8506006 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Waiting for Gaia-try before landing: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=a56d4123cd82 ...that Gij run takes soooooo looooong.
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•