Review history inconsistently uses "a day" vs "N hours" for duration




5 years ago
5 years ago


(Reporter: emorley, Unassigned)



Firefox Tracking Flags

(Not tracked)




5 years ago
When I look at the review page for me, I see these entries:

2014-05-29 - reassigned to <snip> - duration: a day - bug 1017559

I reassigned the review after 16 hours (bug 1017559 comment 9), so I thought that perhaps anything greater than N hours was just being rounded up to a day.

However there is this entry:

2014-06-16 - review+ - duration: 18 hours - bug 1026280

...which didn't get rounded up to "a day".

I haven't had a chance to look at the code, but I'm guessing we're treating after midnight as "a day"? And that the code isn't taking into account local vs server timezone? (For the first bug above, the review was requested 1am my time, so really it wasn't "a day").

I think perhaps to reduce confusion we should just put N hours if N < 24, for simplicity and UX-consistency?
It should be possible to display the times according to the user's timezone -- right now I believe everything is in server time. The actual formatting is handled by momentjs (
You need to log in before you can comment on or make changes to this bug.