1072203 - [Contacts] [Facebook] Friends list proposal for linking seems to be visually incorrect

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, enhancement)

Description

[Jose Manuel Cantera]

See the header for importing and the header for linking. They have different colors. The headers colors should be the same I think.

On the other hand we had in the pas a specific FB blue header for these screens. I don't know if they should be kept or the change is intentional. In any case they should be the same in the import list and in the link list. 

ni Fang to get more info and details on this.

Comment 1

[Jose Manuel Cantera]

Attachment: friend_list.png

Comment 2

[Jose Manuel Cantera]

Attachment: link_capture.png

Comment 3

[Fang Shih [:fang]]

Hi Jose, 
Yes, You are right. Both of them should using comms color for the header, since both views showing as already imported in comms app. Can we change the linking list header to comms green as well? Please let me know if you have any question : ) Thanks!

Comment 4

[Jose Manuel Cantera]

Attachment: 24462.html

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8495753 [details]
24462.html

LGTM, thanks, good catch

Comment 6

[Jose Manuel Cantera]

landed in master:

https://github.com/mozilla-b2g/gaia/commit/d016d8dd19d32d69ed5cec884212100a641309e1

Comment 7

[Jose Manuel Cantera]

Comment on attachment 8495753 [details]
24462.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Gaia-headers web components
[User impact] if declined: Bad user perception and unconsistent app image
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Null. Only HTML changes
[String changes made]:

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 8495753 [details]
24462.html

low risk polish changes, html only..looks good to land.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/b8aefc96daa6a1bcb8effd9a41a9cc471accaf32

Comment 10

[Lance（leave from Mozilla）]

This issue has been verified successfully on Flame 2.1, 2.2.
See attachment: 1015.MP4
Reproducing rate: 0/5

Step:
1.Launch Contacts.
2.Tap Settings, then turn on "Sync friends".
3.Input a correct account and password to enter import page.
4.Back to Contact, and then create a new contact.
5.Tap the contact to view, tap "Link contact".

Actual result:
The headers colors are the same of step 3 and 5.

Flame 2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141202.034824
FW-Date         Tue Dec  2 03:48:34 EST 2014
Bootloader      L1TC00011880

Flame 2.2 version:
Gaia-Rev        725685831f5336cf007e36d9a812aad689604695
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5
Build-ID        20141202040207
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141202.072347
FW-Date         Tue Dec  2 07:23:58 EST 2014
Bootloader      L1TC00011880

Comment 11

[Lance（leave from Mozilla）]

Attachment: 1015.MP4