1072295 - Update timestamp when SkipCutBuffer cut ABuffer data in ACodec

Status: RESOLVED INACTIVE

(Core :: Audio/Video: Playback, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #1052206 +++

Same fix to attachment 8493313 [details] [diff] [review] in Bug 1052206 is also necessary to ACodec. It is not addressed, mp3 playback start could have a tick noise/silence gap.

Comment 1

[Sotaro Ikeda [:sotaro]]

brsun, isn't this bug necessary to enable MediaCodec for audio decoding?

Comment 2

[Bruce Sun [:brsun]]

Whoops, add ni myself back. Let me check it first.

Comment 3

[Bruce Sun [:brsun]]

Indeed. This bug also needs to be fixed on ACodec.

I am thinking the possibility to move the timestamps recalculation from OMXCodec/ACodec into SkipCutBuffer itself.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Bruce Sun [:brsun] from comment #3)
> Indeed. This bug also needs to be fixed on ACodec.
> 
> I am thinking the possibility to move the timestamps recalculation from
> OMXCodec/ACodec into SkipCutBuffer itself.

I did not do that in Bug 1052206, because it need modification to both OMXCodec and SkipCutBuffer. But if we need to modify both SkipCutBuffe and ACodec. Modifying SkipCutBuffer seems make sense. Just modify SkipCutBuffer::submit() might be simpler.

Comment 5

[Nils Ohlmeier [:drno]]

Mass closing do to inactivity.
Feel free to re-open if still needed.