The PNG codecs could use some minor cleanup: The encoder uses PR_fprintf for error messages while the decoder uses PR_LOG. longjmp() should be replaced with png_longjmp(). Support for libpng versions prior to 1.5.0 can be removed. There is an #if 0/#endif block that can be removed. There are a couple of trailing blanks, that should be removed. There are some long lines that need to be wrapped.
Created attachment 8494560 [details] [diff] [review] v01 clean up image/png codecs I uploaded the wrong file; the v00 patch was truncated.
Attachment #8494557 - Attachment is obsolete: true
Created attachment 8494616 [details] [diff] [review] v02 clean up image/png codecs Wrapped a couple of overlooked long lines; alphabetized "#include" lines, changed some remaining c-style comments to "//"
Attachment #8494560 - Attachment is obsolete: true
Created attachment 8494617 [details] [diff] [review] v02 clean up image/png codecs
Attachment #8494616 - Attachment is obsolete: true
Attachment #8494616 - Attachment description: v01 clean up image/png codecs → v02 clean up image/png codecs
Created attachment 8494889 [details] [diff] [review] v03 clean up image/png codecs Adds header guard nsPNGEncoder_h Changes header guard nsPNGDecoder_h__ to nsPNGDecoder_h Alphabetizes #include directives where possible
Attachment #8494617 - Attachment is obsolete: true
I don't have plans for any further updates to this patch. Time for a try-server run? It builds fine on my local 64-bit Ubuntu 14.04LTS platform.
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7) > https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=239efc2fde8a Returns "Unknown revision ID." Does that mean there's something wrong with the patch, or something wrong with treeherder?
We were having infra issues yesterday that caused TH to miss pushes. https://tbpl.mozilla.org/?tree=Try&rev=239efc2fde8a
Try was green.
Attachment #8494889 - Flags: review?(jmuizelaar)
Attachment #8494889 - Flags: review?(jmuizelaar) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.