Closed
Bug 1072340
Opened 11 years ago
Closed 11 years ago
Clean up PNG codecs, use PR_LOG not PR_fprintf for errors
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
VERIFIED
FIXED
mozilla35
People
(Reporter: glennrp+bmo, Assigned: glennrp+bmo)
References
Details
Attachments
(1 file, 4 obsolete files)
|
29.14 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
The PNG codecs could use some minor cleanup:
The encoder uses PR_fprintf for error messages while the decoder uses PR_LOG.
longjmp() should be replaced with png_longjmp().
Support for libpng versions prior to 1.5.0 can be removed.
There is an #if 0/#endif block that can be removed.
There are a couple of trailing blanks, that should be removed.
There are some long lines that need to be wrapped.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
I uploaded the wrong file; the v00 patch was truncated.
Attachment #8494557 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Comment 3•11 years ago
|
||
Wrapped a couple of overlooked long lines; alphabetized "#include" lines, changed some remaining c-style comments to "//"
Attachment #8494560 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8494616 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8494616 -
Attachment description: v01 clean up image/png codecs → v02 clean up image/png codecs
|
|
Assignee | |
Comment 5•11 years ago
|
||
Adds header guard nsPNGEncoder_h
Changes header guard nsPNGDecoder_h__ to nsPNGDecoder_h
Alphabetizes #include directives where possible
Attachment #8494617 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•11 years ago
|
||
I don't have plans for any further updates to this patch. Time for a try-server run? It builds fine on my local 64-bit Ubuntu 14.04LTS platform.
Flags: needinfo?(ryanvm)
|
||
Comment 7•11 years ago
|
||
Flags: needinfo?(ryanvm)
|
|
Assignee | |
Comment 8•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7)
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=239efc2fde8a
Returns "Unknown revision ID." Does that mean there's something wrong
with the patch, or something wrong with treeherder?
Flags: needinfo?(ryanvm)
|
|
||
Comment 9•11 years ago
|
||
We were having infra issues yesterday that caused TH to miss pushes.
https://tbpl.mozilla.org/?tree=Try&rev=239efc2fde8a
Flags: needinfo?(ryanvm)
|
|
Assignee | |
Comment 10•11 years ago
|
||
Try was green.
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8494889 -
Flags: review?(jmuizelaar)
|
||
Updated•11 years ago
|
Attachment #8494889 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 11•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 12•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
|
Assignee | |
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•