1072345 - Screenshot icon saves in Download folder in the OS instead of Images folder

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Pascal Chevrel:pascalc]

Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0

1/ Click on screenshot icon

expected:
Screenshot saved in the Images OS folder

actual:
Screenshot saved in the Downloads OS folder


Since Firefox saves the screenshot in the Downloads folder, that means it asks the OS to provide this path, so we should ask for the Images folder instead since we are not downloading anything.

Comment 1

[Zac Svoboda :zacnomore]

Still saves to downloads folder as of Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0

Comment 2

[Connor Pearson]

Attachment: Bug 1072345 - Change devtools screenshot save location. r=#devtools-reviewers

Comment 3

[Connor Pearson]

I started working on a patch for this. It changes the behavior of saving to first check the preference devtools.screenshot.download.dir then use a default fallback if it's not set.

For macOS, I tried extending it further to use as the default location the directory the user has configured for the system screenshot app. I'm not too familiar with c++ though, so I have no idea if I took the right approach here. I believe it could also be extended for Windows/Linux but I'm not able to test on those devices.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1337c522b219
Change devtools screenshot save location. r=devtools-reviewers,xpcom-reviewers,nchevobbe,mstange,nika

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1337c522b219