1072404 - Firefox may crash when the D3D device is removed while rendering

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

Attachment: Attempt to deal with a resetting rendering device.

We can try to deal with it. We cannot reproduce this scenario but we can see from our crash stats it's responsible for some percentage of our OOM|small crashes. This patch is a stab at trying to deal with it and recovering.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/78a51f809f08

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 8494638 [details] [diff] [review]
Attempt to deal with a resetting rendering device.

This patch has severely reduced the amount of OOM|small on nightly, it'd be good to uplift this to reduce our crash rates.

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: OOM|small crashes
[Describe test coverage new/current, TBPL]: Nightly
[Risks and why]: Very low
[String/UUID change made/needed]: None

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Bas apparently forgot to mark the bug after landing it on Aurora/Beta.

https://hg.mozilla.org/releases/mozilla-aurora/rev/6e317e075d04
https://hg.mozilla.org/releases/mozilla-beta/rev/3d41bbe16481

Comment 5

[Ryan VanderMeulen [:RyanVM]]

And inbound at that...