Closed
Bug 1072423
Opened 9 years ago
Closed 9 years ago
Autophone - support split APKs for 2.3/later
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(fennec35+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fennec | 35+ | --- |
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
4.88 KB,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
bug 1039789 will introduce separate builds for 2.3 devices. We will need to support this in Autophone. We can probably do this in a similar fashion to how we supported armv6/x86.
Updated•9 years ago
|
Summary: Autophone - support split apks for 2.3/later → Autophone - support split APKs for 2.3/later
Updated•9 years ago
|
tracking-fennec: --- → 36+
Updated•9 years ago
|
tracking-fennec: 36+ → 35+
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8533170 -
Flags: review?(mcote)
Comment 2•9 years ago
|
||
Comment on attachment 8533170 [details] [diff] [review] bug-1072423-split-apk.patch Review of attachment 8533170 [details] [diff] [review]: ----------------------------------------------------------------- lgtm. Feels like there's some ever-growing redundancies (same literal strings used in various places) but that can be refactored later.
Attachment #8533170 -
Flags: review?(mcote) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Yeah, I think I need to parameterize much of this as well. Thanks. https://github.com/mozilla/autophone/commit/6098a6963d3759f8fa6c0ce21cf2c9271da89c9c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•9 years ago
|
||
The change to api 11 broke the previous patch. I also found an inconsistency in how autophone.py and worker.py handle checking for incompatible builds. I've gone ahead and pushed a fix to keep autophone production testing api-11 builds. https://github.com/mozilla/autophone/commit/a0532d71ed64390fd3c1a6d057c21a48823eaeae
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•